35059[TASK] Remove conf.php from ext:tstemplate
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Frank Nägler +1
-
Verified V +2
- Stefan Neufeind +2
- Frank Nägler +1
Issues 1
Files 5
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateConstantEditorModuleFunctionController.php2+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php3+10 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php2+2 −2
- typo3/sysext/tstemplate/ts/conf.phpdeleted+0 −6
- typo3/sysext/tstemplate/ext_tables.php+12 −1
Review log 16
-
Wouter Wolters uploaded patch set 1 12/04/14, 22:27
-
Wouter Wolters updated the commit message in patch set 2 12/04/14, 22:40
-
Wouter Wolters wrote 12/05/14, 16:39
Topic set to conf-php -
Stefan Neufeind voted on patch set 2 CR +1 V +1 12/07/14, 10:48
-
Frank Nägler commented on patch set 2 12/07/14, 17:20
TypoScriptTemplateModuleController.php:85removed? sure? -
Stefan Neufeind commented on patch set 2 CR -1 12/07/14, 17:40
basically works, but we need the access-check -
Frank Nägler commented on patch set 2 CR -1 12/07/14, 17:58
Fatal error: Cannot access protected property TYPO3\CMS\Tstemplate\Controller\TypoScriptTemplateModuleController::$moduleName in /Volumes/GitWorkspace/TYPO3/typo3_src-git/typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateConstantEditorModuleFunctionController.php on line 124 Happens if you open the Constant-Editor -
Stefan Neufeind commented on patch set 2 12/07/14, 17:59
TypoScriptTemplateConstantEditorModuleFunctionController.php:124access to this (private) variable is not possible from here (as Frank mentioned)TypoScriptTemplateObjectBrowserModuleFunctionController.php:78also here access to the variable not possible (private) -
Stefan Neufeind voted on patch set 2 V 0 12/07/14, 17:59
-
Stefan Neufeind voted on patch set 2 V -1 12/07/14, 18:00
-
Helmut Hummel commented on patch set 2 CR -1 12/07/14, 18:13
TypoScriptTemplateModuleController.php:85Replyvery good point! This must not be removed! -
Frank Nägler uploaded patch set 3 12/07/14, 22:18
-
Frank Nägler commented on patch set 2 12/07/14, 22:19
fixed the problemsTypoScriptTemplateConstantEditorModuleFunctionController.php:124ReplyDoneTypoScriptTemplateModuleController.php:85Replycan now be removed, since the patch for check in dispatcherTypoScriptTemplateObjectBrowserModuleFunctionController.php:78ReplyDone -
Frank Nägler voted on patch set 3 V +1 CR +1 12/07/14, 22:19
-
Stefan Neufeind voted on patch set 3 CR +2 V +2 12/07/14, 22:22
-
Stefan Neufeind merged patch set 3 12/07/14, 22:22