Review main Merged

35059[TASK] Remove conf.php from ext:tstemplate

Wouter Wolters CR +2 V +2 Easy +25 −11 updated 12/07/14, 22:22

Commit message

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Frank Nägler +1
  • Verified V +2
    • Stefan Neufeind +2
    • Frank Nägler +1

Issues 1

Files 5

Review log 16

  1. Wouter Wolters uploaded patch set 1 12/04/14, 22:27

  2. Wouter Wolters updated the commit message in patch set 2 12/04/14, 22:40

  3. Wouter Wolters wrote 12/05/14, 16:39

    Topic set to conf-php
  4. Stefan Neufeind voted on patch set 2 CR +1 V +1 12/07/14, 10:48

  5. Frank Nägler commented on patch set 2 12/07/14, 17:20

    TypoScriptTemplateModuleController.php:85

    removed? sure?
  6. Stefan Neufeind commented on patch set 2 CR -1 12/07/14, 17:40

    basically works, but we need the access-check
  7. Frank Nägler commented on patch set 2 CR -1 12/07/14, 17:58

    Fatal error: Cannot access protected property TYPO3\CMS\Tstemplate\Controller\TypoScriptTemplateModuleController::$moduleName in /Volumes/GitWorkspace/TYPO3/typo3_src-git/typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateConstantEditorModuleFunctionController.php on line 124 Happens if you open the Constant-Editor
  8. Stefan Neufeind commented on patch set 2 12/07/14, 17:59

    TypoScriptTemplateConstantEditorModuleFunctionController.php:124

    access to this (private) variable is not possible from here (as Frank mentioned)

    TypoScriptTemplateObjectBrowserModuleFunctionController.php:78

    also here access to the variable not possible (private)
  9. Stefan Neufeind voted on patch set 2 V 0 12/07/14, 17:59

  10. Stefan Neufeind voted on patch set 2 V -1 12/07/14, 18:00

  11. Helmut Hummel commented on patch set 2 CR -1 12/07/14, 18:13

    TypoScriptTemplateModuleController.php:85 Reply

    very good point! This must not be removed!
  12. Frank Nägler uploaded patch set 3 12/07/14, 22:18

  13. Frank Nägler commented on patch set 2 12/07/14, 22:19

    fixed the problems

    TypoScriptTemplateConstantEditorModuleFunctionController.php:124 Reply

    Done

    TypoScriptTemplateModuleController.php:85 Reply

    can now be removed, since the patch for check in dispatcher

    TypoScriptTemplateObjectBrowserModuleFunctionController.php:78 Reply

    Done
  14. Frank Nägler voted on patch set 3 V +1 CR +1 12/07/14, 22:19

  15. Stefan Neufeind voted on patch set 3 CR +2 V +2 12/07/14, 22:22

  16. Stefan Neufeind merged patch set 3 12/07/14, 22:22