35062[TASK] Remove conf.php from ext:setup
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
Issues 1
Files 3
Review log 20
-
Wouter Wolters uploaded patch set 1 12/04/14, 22:53
-
Wouter Wolters wrote 12/05/14, 16:39
Topic set to conf-php -
Stefan Neufeind voted on patch set 1 CR +1 V +1 12/07/14, 10:46
-
Stefan Neufeind commented on patch set 1 CR -1 12/07/14, 17:40
basically works, but we need the access-check -
Frank Nägler commented on patch set 1 CR -1 12/07/14, 17:45
Fatal error: Cannot access protected property TYPO3\CMS\Tstemplate\Controller\TypoScriptTemplateModuleController::$moduleName in /Volumes/GitWorkspace/TYPO3/typo3_src-git/typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateConstantEditorModuleFunctionController.php on line 124 -
Frank Nägler commented on patch set 1 12/07/14, 17:58
please ignore my last comment, wrong patch. -
Stefan Neufeind commented on patch set 1 CR +1 12/07/14, 22:24
fine now, since the access-patch is now merged (check done in mod.php) -
Stefan Neufeind commented on patch set 1 CR -1 V 0 12/07/14, 22:25
moduleName must be public -
Frank Nägler uploaded patch set 2 12/07/14, 22:27
-
Frank Nägler voted on patch set 2 V +1 CR +1 12/07/14, 22:28
-
Markus Klein commented on patch set 2 12/08/14, 01:36
SetupModuleController.php:30unused now, should be removed. -
Markus Klein uploaded patch set 3 12/08/14, 02:50
-
Markus Klein voted on patch set 3 CR +1 V +1 12/08/14, 02:51
-
Anja Leichsenring voted on patch set 3 CR +2 V +2 12/12/14, 19:51
-
Christian Kuhn commented on patch set 3 12/12/14, 19:56
SetupModuleController.php:131protected?? -
Christian Kuhn uploaded patch set 4 12/12/14, 19:57
-
Christian Kuhn voted on patch set 4 CR +1 V +1 12/12/14, 19:59
-
Anja Leichsenring voted on patch set 4 CR +1 V +1 12/12/14, 20:15
-
Christian Kuhn voted on patch set 4 CR +2 V +2 12/12/14, 20:23
-
Christian Kuhn merged patch set 4 12/12/14, 20:23