Review main Merged

35062[TASK] Remove conf.php from ext:setup

Wouter Wolters CR +2 V +2 Easy +22 −16 updated 12/12/14, 20:23

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1

Issues 1

Files 3

Review log 20

  1. Wouter Wolters uploaded patch set 1 12/04/14, 22:53

  2. Wouter Wolters wrote 12/05/14, 16:39

    Topic set to conf-php
  3. Stefan Neufeind voted on patch set 1 CR +1 V +1 12/07/14, 10:46

  4. Stefan Neufeind commented on patch set 1 CR -1 12/07/14, 17:40

    basically works, but we need the access-check
  5. Frank Nägler commented on patch set 1 CR -1 12/07/14, 17:45

    Fatal error: Cannot access protected property TYPO3\CMS\Tstemplate\Controller\TypoScriptTemplateModuleController::$moduleName in /Volumes/GitWorkspace/TYPO3/typo3_src-git/typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateConstantEditorModuleFunctionController.php on line 124
  6. Frank Nägler commented on patch set 1 12/07/14, 17:58

    please ignore my last comment, wrong patch.
  7. Stefan Neufeind commented on patch set 1 CR +1 12/07/14, 22:24

    fine now, since the access-patch is now merged (check done in mod.php)
  8. Stefan Neufeind commented on patch set 1 CR -1 V 0 12/07/14, 22:25

    moduleName must be public
  9. Frank Nägler uploaded patch set 2 12/07/14, 22:27

  10. Frank Nägler voted on patch set 2 V +1 CR +1 12/07/14, 22:28

  11. Markus Klein commented on patch set 2 12/08/14, 01:36

    SetupModuleController.php:30

    unused now, should be removed.
  12. Markus Klein uploaded patch set 3 12/08/14, 02:50

  13. Markus Klein voted on patch set 3 CR +1 V +1 12/08/14, 02:51

  14. Anja Leichsenring voted on patch set 3 CR +2 V +2 12/12/14, 19:51

  15. Christian Kuhn commented on patch set 3 12/12/14, 19:56

    SetupModuleController.php:131

    protected??
  16. Christian Kuhn uploaded patch set 4 12/12/14, 19:57

  17. Christian Kuhn voted on patch set 4 CR +1 V +1 12/12/14, 19:59

  18. Anja Leichsenring voted on patch set 4 CR +1 V +1 12/12/14, 20:15

  19. Christian Kuhn voted on patch set 4 CR +2 V +2 12/12/14, 20:23

  20. Christian Kuhn merged patch set 4 12/12/14, 20:23