Review main Merged

35063[TASK] Remove conf.php from ext:scheduler

Wouter Wolters CR +2 V +2 Easy +24 −11 updated 12/07/14, 17:38

Commit message

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Issues 1

Files 3

Review log 6

  1. Wouter Wolters uploaded patch set 1 12/04/14, 23:02

  2. Markus Klein voted on patch set 1 CR +1 V +1 12/04/14, 23:12

  3. Wouter Wolters wrote 12/05/14, 16:39

    Topic set to conf-php
  4. Stefan Neufeind voted on patch set 1 CR +2 V +2 12/07/14, 10:28

  5. Stefan Neufeind merged patch set 1 12/07/14, 10:28

  6. Stefan Neufeind commented on patch set 2 12/07/14, 17:38

    post-1: access-check needed

    SchedulerModuleController.php:84

    We must not remove the access-check!