Review main Merged

35064[TASK] Remove conf.php from ext:recycler

Wouter Wolters CR +2 V +2 Easy +24 −10 updated 12/08/14, 01:40

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Neufeind +1

Issues 1

Files 3

Review log 13

  1. Wouter Wolters uploaded patch set 1 12/04/14, 23:11

  2. Markus Klein voted on patch set 1 CR +1 V +1 12/04/14, 23:20

  3. Markus Klein commented on patch set 1 CR -1 V -1 12/04/14, 23:20

    ext_tables.php:17

    wrong!!
  4. Markus Klein uploaded patch set 2 12/04/14, 23:21

  5. Markus Klein voted on patch set 2 CR +1 V +1 12/04/14, 23:21

  6. Wouter Wolters wrote 12/05/14, 16:40

    Topic set to conf-php
  7. Stefan Neufeind commented on patch set 2 CR -1 12/07/14, 10:22

    ext_tables.php:18

    Should be web_ I guess?
  8. Stefan Neufeind uploaded patch set 3 12/07/14, 10:23

  9. Stefan Neufeind commented on patch set 3 CR +1 V +1 12/07/14, 10:26

    Fixed module-name in ext_tables.php
  10. Stefan Neufeind commented on patch set 3 CR -1 12/07/14, 17:41

    basically works, but we need the access-check
  11. Stefan Neufeind voted on patch set 3 CR +1 12/07/14, 23:11

  12. Markus Klein voted on patch set 3 CR +2 V +2 12/08/14, 01:39

  13. Markus Klein merged patch set 3 12/08/14, 01:40