Review main Merged

35072[TASK] Remove conf.php from ext:recordlist

Wouter Wolters CR +2 V +2 Easy +22 −13 updated 12/07/14, 17:39

Commit message

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Issues 1

Files 3

Review log 8

  1. Wouter Wolters uploaded patch set 1 12/05/14, 16:15

  2. Wouter Wolters wrote 12/05/14, 16:39

    Topic set to conf-php
  3. Wouter Wolters commented on patch set 1 12/05/14, 18:16

    Please change on submit or change

    RecordList.php:136

    @deprecated since TYPO3 CMS 7, will be removed in TYPO3 CMS 8
  4. Markus Klein uploaded patch set 2 12/06/14, 00:12

  5. Markus Klein voted on patch set 2 CR +1 V +1 12/06/14, 00:13

  6. Stefan Neufeind commented on patch set 2 CR +2 V +2 12/07/14, 10:14

    Tested that icon and text still appear. User is able to see the module or not (depending on his rights). Looks good imho.
  7. Stefan Neufeind merged patch set 2 12/07/14, 10:14

  8. Stefan Neufeind commented on patch set 3 12/07/14, 17:39

    post-1: we need the access-check

    RecordList.php:165

    We must not remove the access-check!