Review main Merged

35074[TASK] Remove conf.php from ext:info

Wouter Wolters CR +2 V +2 Easy +25 −10 updated 12/10/14, 17:13

Commit message

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Markus Klein +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Markus Klein +1

Issues 1

Files 3

Review log 11

  1. Wouter Wolters uploaded patch set 1 12/05/14, 16:26

  2. Wouter Wolters wrote 12/05/14, 16:40

    Topic set to conf-php
  3. Stefan Neufeind voted on patch set 1 CR +1 V +1 12/07/14, 10:43

  4. Stefan Neufeind commented on patch set 1 CR -1 12/07/14, 17:40

    basically works, but we need the access-check
  5. Stefan Neufeind uploaded patch set 2 12/07/14, 22:52

  6. Stefan Neufeind voted on patch set 2 CR +1 12/07/14, 22:53

  7. Stefan Neufeind commented on patch set 2 V -1 CR 0 12/07/14, 23:00

    Hmm, does not work? "Wrong modulename" What do I miss? Shouldn't it have been set by the ext_tables.php?
  8. Markus Klein uploaded patch set 3 12/08/14, 02:47

  9. Markus Klein voted on patch set 3 CR +1 V +1 12/08/14, 02:48

  10. Tymoteusz Motylewski voted on patch set 3 CR +2 V +2 12/10/14, 17:13

  11. Tymoteusz Motylewski merged patch set 3 12/10/14, 17:13