Review main Merged

35076[TASK] Remove conf.php from ext:cshmanual

Wouter Wolters CR +2 V +2 Easy +12 −7 updated 12/08/14, 02:03

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Neufeind +1

Issues 1

Files 2

Review log 8

  1. Wouter Wolters uploaded patch set 1 12/05/14, 16:34

  2. Wouter Wolters wrote 12/05/14, 16:40

    Topic set to conf-php
  3. Stefan Neufeind voted on patch set 1 CR +1 V +1 12/07/14, 10:39

  4. Stefan Neufeind commented on patch set 1 12/07/14, 10:41

    We don't have a moduleName, MCONF etc. like in the other modules. Is that correct since it's a different type of module?
  5. Stefan Neufeind commented on patch set 1 CR -1 12/07/14, 17:40

    basically works, but we need the access-check
  6. Stefan Neufeind voted on patch set 1 CR +1 12/07/14, 23:11

  7. Markus Klein voted on patch set 1 CR +2 V +2 12/08/14, 02:03

  8. Markus Klein merged patch set 1 12/08/14, 02:03