Review main Merged

35080[TASK] Streamline deprecation message to one format

Wouter Wolters CR +2 V +2 Normal +75 −75 updated 12/07/14, 19:51

Commit message

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 26

Show 6 more files

Review log 11

  1. Wouter Wolters uploaded patch set 1 12/05/14, 18:20

  2. Stefan Neufeind commented on patch set 1 12/05/14, 19:55

    LegacyClassesForIde001.php:5

    not 6.0? changed by intention?

    PageGenerator.php:215

    We can't use a plain GeneralUtility::logDeprecatedFunction(); here I guess?
  3. Markus Klein commented on patch set 1 CR +1 12/06/14, 00:57

    The one question of Stefan is interesting

    ClickMenu.php:1179

    space missing

    PageGenerator.php:215 Reply

    Nope since we can only deprecate the FuncCalls but not this function, which is of course still called by the Core.
  4. Wouter Wolters commented on patch set 1 12/06/14, 10:59

    ClickMenu.php:1179 Reply

    Done

    LegacyClassesForIde001.php:5 Reply

    Done
  5. Wouter Wolters uploaded patch set 2 12/06/14, 10:59

  6. Stefan Neufeind voted on patch set 2 CR +1 12/06/14, 11:13

  7. Markus Klein voted on patch set 2 V +1 CR +1 12/06/14, 13:50

  8. Frank Nägler commented on patch set 2 CR -1 12/07/14, 15:42

    -1 until my comment is answered, with rest I am fine.

    PageRenderer.php:1382

    why CMS 9 and not CMS 8?
  9. Stefan Neufeind uploaded patch set 3 12/07/14, 19:50

  10. Stefan Neufeind commented on patch set 3 CR +2 V +2 12/07/14, 19:51

    @Frank: That one "CMS 9" should of course have been "CMS 8" as it was until now. Copy-n-paste error, Wouter explained. I'm taking all other approvals into account. We're through with this.
  11. Stefan Neufeind merged patch set 3 12/07/14, 19:51