Review main Merged

35084[TASK] Streamline Wizard-Controllers

Frank Nägler CR +2 V +2 Hard +198 −189 updated 12/06/14, 12:46

Commit message

This patch introduce an abstract wizard controller to
remove duplicate code and prevent the usage of
$GLOBALS in a lot of places.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 8

Review log 6

  1. Frank Nägler uploaded patch set 1 12/05/14, 19:53

  2. Stefan Neufeind commented on patch set 1 12/05/14, 23:28

    Maybe also add a __construct() to the AbstractWizardController for the common case (3 lines) and leave the rest up to an init() that gets overwritten (maybe calling parent::init()?) in each Controller?

    AbstractWizardController.php:7

    We usually have the namespace on top like here (afaik required), but then the license-header and after that use-statements. Right?

    AbstractWizardController.php:25

    Do we still use @package? I'm not sure about that one.

    AbstractWizardController.php:43

    Imho simply cast the result to (bool).
  3. Markus Klein uploaded patch set 2 12/06/14, 00:48

  4. Markus Klein voted on patch set 2 CR +1 V +1 12/06/14, 00:49

  5. Wouter Wolters voted on patch set 2 V +2 CR +2 12/06/14, 12:46

  6. Wouter Wolters merged patch set 2 12/06/14, 12:46