35084[TASK] Streamline Wizard-Controllers
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Issues 1
Files 8
- typo3/sysext/backend/Classes/Controller/Wizard/AbstractWizardController.php3new+103 −0
- typo3/sysext/backend/Classes/Controller/Wizard/AddController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Wizard/ColorpickerController.php+14 −14
- typo3/sysext/backend/Classes/Controller/Wizard/EditController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Wizard/FormsController.php+40 −71
- typo3/sysext/backend/Classes/Controller/Wizard/ListController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Wizard/RteController.php+13 −45
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php+22 −53
Review log 6
-
Frank Nägler uploaded patch set 1 12/05/14, 19:53
-
Stefan Neufeind commented on patch set 1 12/05/14, 23:28
Maybe also add a __construct() to the AbstractWizardController for the common case (3 lines) and leave the rest up to an init() that gets overwritten (maybe calling parent::init()?) in each Controller?AbstractWizardController.php:7We usually have the namespace on top like here (afaik required), but then the license-header and after that use-statements. Right?AbstractWizardController.php:25Do we still use @package? I'm not sure about that one.AbstractWizardController.php:43Imho simply cast the result to (bool). -
Markus Klein uploaded patch set 2 12/06/14, 00:48
-
Markus Klein voted on patch set 2 CR +1 V +1 12/06/14, 00:49
-
Wouter Wolters voted on patch set 2 V +2 CR +2 12/06/14, 12:46
-
Wouter Wolters merged patch set 2 12/06/14, 12:46