Review main Merged

35090[CLEANUP] Clarify configuration preset description

Helmut Hummel CR +2 V +2 Easy +12 −16 updated 12/13/14, 13:45

Commit message

The description of the configuration preset in
install tool is a bit misleading which causes people
to confuse this with the Application Context feature.

Remove the mentioning of application context from context preset
and move it to the top.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 10

  1. Helmut Hummel uploaded patch set 1 12/05/14, 23:52

  2. Markus Klein commented on patch set 1 12/06/14, 00:03

    We should still mention that the application context influences the selected preset. (the priorities are shifted if I remember correctly)

    Configuration.html:17

    Do we usually have such direct links "somewhere" in the code?

    Configuration.html:17

    superfluous space
  3. Helmut Hummel commented on patch set 1 12/06/14, 00:13

    > We should still mention that the application context influences the selected preset I did not know that until now :-O But this is only relevant/Evaluated during first installation when no user interaction is possible, right? If I'm correct, then I would not mention it in the description as it is not relevant.

    Configuration.html:17 Reply

    what is your concern here? afaik the doc team once stated that documentation links should be "stable"
  4. Markus Klein commented on patch set 1 12/06/14, 01:55

    Ok, double checked that now. The priority is only relevant for first setup, so I'm fine with removing the app context from the texts!

    Configuration.html:17 Reply

    Yes, but didn't we try to centralize all urls somewhere in the core? If this is a wrong impression of mine, then this is of course perfectly fine.
  5. Wouter Wolters uploaded patch set 2 12/13/14, 13:18

  6. Wouter Wolters voted on patch set 2 V +1 CR +1 12/13/14, 13:18

  7. Christian Kuhn commented on patch set 2 12/13/14, 13:42

    Small hint: The application context *always* changes the order of this preset. So if Production is set as application context, it will be the first one listed, and dev settings below, but if you set development, the dev preset will be listed first.
  8. Christian Kuhn voted on patch set 2 CR +2 V +2 12/13/14, 13:45

  9. Christian Kuhn merged patch set 2 12/13/14, 13:45

  10. Christian Kuhn commented on patch set 3 12/13/14, 13:45

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 1de815ad83a2572a0d99840bdc13f8b14826e497