Review main Merged

35117[BUGFIX] Autolink urls starting https:// as well

Georg Ringer CR +2 V +2 Normal +56 −51 updated 01/03/15, 15:19

Commit message

Currently only non ssl urls are automatically identified
and transformed to a link. Now also links starting with
https:// are identified.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Markus Klein +1

Issues 1

Files 1

Review log 18

  1. Georg Ringer uploaded patch set 1 12/06/14, 20:36

  2. Stefan Neufeind voted on patch set 1 CR +1 12/07/14, 09:19

  3. Stefan Neufeind commented on patch set 1 12/07/14, 09:22

    Afaik an official term for the "protocol" is "scheme" (afaik also according to some RFC). But with the php-function parse_url() that would be without the ://.
  4. Markus Klein commented on patch set 1 CR +1 12/07/14, 11:15

    ContentObjectRenderer.php:5147

    could really be called $scheme, since the protocol used is in both cases HTTP just with some encryption overlay
  5. Felix Kopp commented on patch set 1 12/07/14, 12:12

    How to test?
  6. Georg Ringer commented on patch set 1 12/07/14, 14:02

    I added a how to reproduce to the forge issue
  7. Stefan Neufeind commented on patch set 1 V +1 12/07/14, 14:13

    Unless somebody wants to rename the variable or so :-) I think the rest should be fine.
  8. Markus Klein voted on patch set 1 V +1 12/08/14, 03:03

  9. Wouter Wolters uploaded patch set 2 12/13/14, 13:09

  10. Wouter Wolters commented on patch set 2 CR +1 12/13/14, 13:10

    Fixed the variable name
  11. Markus Klein commented on patch set 2 CR +1 12/13/14, 13:15

    I need to test that again. especially the last assignment where we reassign the textstr to data.
  12. Anja Leichsenring commented on patch set 2 CR -1 12/13/14, 21:04

    ContentObjectRenderer.php:5206

    this is used nowhere. The input parameter is no reference.
  13. Markus Klein commented on patch set 2 12/13/14, 23:57

    ContentObjectRenderer.php:5206 Reply

    It is used. In the next iteration in line 5149. I need to investigate whether this assignment is ok though
  14. Mathias Schreiber wrote 12/17/14, 20:36

    Topic set to cObj
  15. Markus Klein commented on patch set 2 V +1 01/03/15, 15:15

    ContentObjectRenderer.php:5206 Reply

    Looks good
  16. Anja Leichsenring voted on patch set 2 CR +2 V +2 01/03/15, 15:18

  17. Anja Leichsenring merged patch set 2 01/03/15, 15:18

  18. Anja Leichsenring commented on patch set 3 01/03/15, 15:19

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit c873e02f22a8390c33397b911916b6c5149f6171