35117[BUGFIX] Autolink urls starting https:// as well
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Markus Klein +1
- Wouter Wolters +1
-
Verified V +2
- Anja Leichsenring +2
- Markus Klein +1
Issues 1
Files 1
Review log 18
-
Georg Ringer uploaded patch set 1 12/06/14, 20:36
-
Stefan Neufeind voted on patch set 1 CR +1 12/07/14, 09:19
-
Stefan Neufeind commented on patch set 1 12/07/14, 09:22
Afaik an official term for the "protocol" is "scheme" (afaik also according to some RFC). But with the php-function parse_url() that would be without the ://. -
Markus Klein commented on patch set 1 CR +1 12/07/14, 11:15
ContentObjectRenderer.php:5147could really be called $scheme, since the protocol used is in both cases HTTP just with some encryption overlay -
Felix Kopp commented on patch set 1 12/07/14, 12:12
How to test? -
Georg Ringer commented on patch set 1 12/07/14, 14:02
I added a how to reproduce to the forge issue -
Stefan Neufeind commented on patch set 1 V +1 12/07/14, 14:13
Unless somebody wants to rename the variable or so :-) I think the rest should be fine. -
Markus Klein voted on patch set 1 V +1 12/08/14, 03:03
-
Wouter Wolters uploaded patch set 2 12/13/14, 13:09
-
Wouter Wolters commented on patch set 2 CR +1 12/13/14, 13:10
Fixed the variable name -
Markus Klein commented on patch set 2 CR +1 12/13/14, 13:15
I need to test that again. especially the last assignment where we reassign the textstr to data. -
Anja Leichsenring commented on patch set 2 CR -1 12/13/14, 21:04
ContentObjectRenderer.php:5206this is used nowhere. The input parameter is no reference. -
Markus Klein commented on patch set 2 12/13/14, 23:57
ContentObjectRenderer.php:5206ReplyIt is used. In the next iteration in line 5149. I need to investigate whether this assignment is ok though -
Mathias Schreiber wrote 12/17/14, 20:36
Topic set to cObj -
Markus Klein commented on patch set 2 V +1 01/03/15, 15:15
ContentObjectRenderer.php:5206ReplyLooks good -
Anja Leichsenring voted on patch set 2 CR +2 V +2 01/03/15, 15:18
-
Anja Leichsenring merged patch set 2 01/03/15, 15:18
-
Anja Leichsenring commented on patch set 3 01/03/15, 15:19
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit c873e02f22a8390c33397b911916b6c5149f6171