Review main Merged

35129[CLEANUP] Fix return type of PathUtility::stripPathSitePrefix

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 12/07/14, 20:02

Commit message

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Mathias Schreiber +1
  • Verified V +2
    • Helmut Hummel +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 11

  1. Helmut Hummel uploaded patch set 1 12/07/14, 12:17

  2. Frans Saris voted on patch set 1 CR +1 12/07/14, 13:26

  3. Oliver Klee voted on patch set 1 CR +1 12/07/14, 13:59

  4. Oliver Klee commented on patch set 1 12/07/14, 13:59

    Ticket-ID?
  5. Stefan Neufeind commented on patch set 1 CR -1 12/07/14, 14:16

    add ref to forge-issue please
  6. Stefan Neufeind commented on patch set 1 12/07/14, 14:21

    In the phpdoc in that file there are some newlines too much (between @param and @return etc.). Maybe make this a general phpdoc-cleanup for that file?
  7. Helmut Hummel updated the commit message in patch set 2 12/07/14, 14:48

  8. Mathias Schreiber commented on patch set 2 CR +1 V +1 12/07/14, 14:51

    can we somehow add a fastlane for stuff like this?
  9. Helmut Hummel voted on patch set 2 CR +2 V +2 12/07/14, 14:53

  10. Helmut Hummel merged patch set 2 12/07/14, 14:54

  11. Helmut Hummel commented on patch set 3 12/07/14, 20:02

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit e45a666eccda9882ee5392b20833fcc2471457a9