Review main Merged

35130[TASK] Turn todos into @todo to find them easier, Part 2

Stefan Neufeind CR +2 V +2 Normal +81 −84 updated 12/12/14, 20:09

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +2
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +2

Issues 1

Files 46

Show 26 more files

Review log 13

  1. Stefan Neufeind uploaded patch set 1 12/07/14, 14:41

  2. Stefan Neufeind commented on patch set 1 12/07/14, 14:44

    During another review I came across "// TODO". We somehow didn't include them in the previous changeset. So here is another round.

    adodb-active-recordx.inc.php

    afaik not touch since it's a 3rd-party-lib?

    XRIRes.php

    afaik not touch since it's a 3rd-party-lib?
  3. Markus Klein commented on patch set 1 CR -1 12/08/14, 01:05

    yep, 3rd party must not be touched
  4. Stefan Neufeind uploaded patch set 2 12/08/14, 23:11

  5. Stefan Neufeind commented on patch set 2 12/08/14, 23:12

    removed 3rd-party libs (as parts of adodb and openid)
  6. Christian Kuhn voted on patch set 2 CR +2 V +2 12/12/14, 19:49

  7. Christian Kuhn uploaded patch set 3 12/12/14, 19:57

  8. Christian Kuhn commented on patch set 3 CR +2 V +2 12/12/14, 19:59

    ups, re-pushed by accident.
  9. Wouter Wolters commented on patch set 3 12/12/14, 20:07

    DatabaseConnection.php:3059

    What is here to do?
  10. Christian Kuhn uploaded patch set 4 12/12/14, 20:08

  11. Christian Kuhn voted on patch set 4 CR +2 V +2 12/12/14, 20:08

  12. Wouter Wolters voted on patch set 4 V +2 CR +2 12/12/14, 20:09

  13. Wouter Wolters merged patch set 4 12/12/14, 20:09