35130[TASK] Turn todos into @todo to find them easier, Part 2
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +2
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +2
Issues 1
Files 46
- typo3/sysext/backend/Classes/Form/Element/InlineElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/SuggestElement.php+1 −1
- typo3/sysext/backend/Classes/View/ThumbnailView.php+1 −1
- typo3/sysext/core/Build/UnitTestsBootstrap.php+2 −2
- typo3/sysext/core/Classes/Collection/AbstractRecordCollection.php+2 −2
- typo3/sysext/core/Classes/Database/DatabaseConnection.php+2 −2
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+1 −1
- typo3/sysext/core/Classes/Package/Package.php+3 −3
- typo3/sysext/core/Classes/Resource/Processing/ImageCropScaleMaskTask.php+2 −2
- typo3/sysext/core/Classes/Resource/Processing/ImagePreviewTask.php+3 −2
- typo3/sysext/core/Classes/Resource/FileReference.php+6 −7
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+2 −2
- typo3/sysext/core/Classes/Utility/CommandUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+3 −3
- typo3/sysext/core/Classes/Utility/PathUtility.php+1 −1
- typo3/sysext/core/Tests/UnitTestCase.php+1 −1
- typo3/sysext/dbal/Classes/Database/AdodbPreparedStatement.php+1 −1
- typo3/sysext/dbal/Classes/Database/DatabaseConnection.php1+0 −2
- typo3/sysext/extbase/Classes/Mvc/Controller/Argument.php+1 −1
Show 26 more files
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/GenericObjectValidator.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/Parser/XmlParserFactory.php+2 −4
- typo3/sysext/fluid/Classes/Core/Compiler/TemplateCompiler.php+1 −1
- typo3/sysext/fluid/Classes/Core/Parser/TemplateParser.php+1 −1
- typo3/sysext/fluid/Classes/Core/Widget/WidgetContext.php+1 −1
- typo3/sysext/fluid/Classes/Core/Widget/WidgetRequestBuilder.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+3 −3
- typo3/sysext/form/Classes/Domain/Factory/JsonToTypoScript.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attribute/AcceptAttribute.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attribute/AcceptCharsetAttribute.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+2 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+3 −3
- typo3/sysext/indexed_search/Classes/FileContentParser.php+1 −1
- typo3/sysext/install/Classes/Service/SqlSchemaMigrationService.php+3 −2
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php+1 −1
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+1 −1
- typo3/sysext/lowlevel/Classes/LostFilesCommand.php+3 −3
- typo3/sysext/saltedpasswords/Classes/Utility/ExtensionManagerConfigurationUtility.php+4 −4
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+2 −2
- typo3/sysext/scheduler/Classes/Scheduler.php+2 −2
- typo3/sysext/t3skin/Classes/Slot/IconStyleModifier.php+3 −3
- typo3/sysext/version/Classes/Hook/DataHandlerHook.php+2 −2
- typo3/sysext/version/Classes/Task/AutoPublishTask.php+1 −1
- typo3/sysext/workspaces/Classes/Task/AutoPublishTask.php+1 −1
Review log 13
-
Stefan Neufeind uploaded patch set 1 12/07/14, 14:41
-
Stefan Neufeind commented on patch set 1 12/07/14, 14:44
During another review I came across "// TODO". We somehow didn't include them in the previous changeset. So here is another round.adodb-active-recordx.inc.phpafaik not touch since it's a 3rd-party-lib?XRIRes.phpafaik not touch since it's a 3rd-party-lib? -
Markus Klein commented on patch set 1 CR -1 12/08/14, 01:05
yep, 3rd party must not be touched -
Stefan Neufeind uploaded patch set 2 12/08/14, 23:11
-
Stefan Neufeind commented on patch set 2 12/08/14, 23:12
removed 3rd-party libs (as parts of adodb and openid) -
Christian Kuhn voted on patch set 2 CR +2 V +2 12/12/14, 19:49
-
Christian Kuhn uploaded patch set 3 12/12/14, 19:57
-
Christian Kuhn commented on patch set 3 CR +2 V +2 12/12/14, 19:59
ups, re-pushed by accident. -
Wouter Wolters commented on patch set 3 12/12/14, 20:07
DatabaseConnection.php:3059What is here to do? -
Christian Kuhn uploaded patch set 4 12/12/14, 20:08
-
Christian Kuhn voted on patch set 4 CR +2 V +2 12/12/14, 20:08
-
Wouter Wolters voted on patch set 4 V +2 CR +2 12/12/14, 20:09
-
Wouter Wolters merged patch set 4 12/12/14, 20:09