Review main Merged

35141[TASK] Followup: Remove conf.php from ext:tstemplate

Stefan Neufeind CR +2 V +2 Easy +5 −4 updated 12/12/14, 18:28

Commit message

Get rid of the $moduleName again, use $MCONF['name'] for now.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 3

Review log 9

  1. Stefan Neufeind uploaded patch set 1 12/07/14, 22:45

  2. Stefan Neufeind commented on patch set 1 12/07/14, 22:48

    Helmut suggested to not make the $moduleName public - and since we have the name in MCONF already, continue to use the MCONF['name'] (and not duplicate functionality in this case)
  3. Stefan Neufeind commented on patch set 1 V -1 12/07/14, 23:02

    Doesn't seem to work. "Wrong modulename". We expected this to be set by the ext_tables.php (addModule()).
  4. Stefan Neufeind wrote 12/07/14, 23:03

    Topic set to conf-php
  5. Markus Klein uploaded patch set 2 12/08/14, 02:54

  6. Markus Klein uploaded patch set 3 12/08/14, 02:54

  7. Markus Klein voted on patch set 3 CR +1 V +1 12/08/14, 02:55

  8. Wouter Wolters voted on patch set 3 V +2 CR +2 12/12/14, 18:28

  9. Wouter Wolters merged patch set 3 12/12/14, 18:28