Review main Merged

35170[BUGFIX] Remove unneeded file_edit check

Benni Mack CR +2 V +2 Easy +1 −2 updated 12/08/14, 23:16

Commit message

There is a left-over code after
file_edit.php was removed from
the core in 7.1 development.

The patch removes the check.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Neufeind +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 5

  1. Benni Mack uploaded patch set 1 12/08/14, 20:41

  2. Wouter Wolters updated the commit message in patch set 2 12/08/14, 20:49

  3. Wouter Wolters commented on patch set 2 V +1 CR +1 12/08/14, 20:50

    Easy to test / review: There is no file_edit.php there anymore.
  4. Stefan Neufeind commented on patch set 2 CR +2 V +2 12/08/14, 23:16

    No file_edit.php anymore. References to that "filename" still inside core are hooks/xlf-references which is a separate thing.
  5. Stefan Neufeind merged patch set 2 12/08/14, 23:16