Review main Merged

35181[BUGFIX] Ensure argument is an array in ContentObjectRenderer

Stefan Froemken CR +2 V +2 Easy +1 −1 updated 12/13/14, 14:49

Commit message

This patch ensures that at least an empty array is passed to the
array_replace_recursive function to avoid warnings during rendering.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 9

  1. Stefan Froemken uploaded patch set 1 12/09/14, 09:57

  2. Andreas Kienast voted on patch set 1 CR +1 12/09/14, 10:00

  3. Stefan Neufeind voted on patch set 1 CR +1 12/09/14, 10:27

  4. Anja Leichsenring voted on patch set 1 CR +1 V +1 12/13/14, 14:09

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 12/13/14, 14:19

  6. Christian Kuhn merged patch set 1 12/13/14, 14:19

  7. Christian Kuhn commented on patch set 2 12/13/14, 14:19

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 83d745e13cdf146e89dad8695a08febee69b534e
  8. Helmut Hummel commented on patch set 2 12/13/14, 14:24

    post -1 by reading

    ContentObjectRenderer.php:7011

    This should have been: $conf = is_array($conf) ? array_replace_recursive($conf, $old_conf) : $old_conf
  9. Anja Leichsenring commented on patch set 2 12/13/14, 14:49