35203[FEATURE] Add AJAX logic for delete records in ListModule
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Benjamin Kott +1
-
Verified V +2
- Benni Mack +2
- Stefan Froemken +1
- Benjamin Kott +1
Issues 1
Files 6
- typo3/sysext/backend/Classes/Controller/SimpleDataHandlerController.php+4 −0
- typo3/sysext/backend/Resources/Public/JavaScript/AjaxDataHandler.js17+104 −8
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+6 −0
- typo3/sysext/lang/locallang_mod_web_list.xlf+7 −0
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php2+10 −11
- typo3/sysext/recordlist/Classes/RecordList.php+1 −0
Review log 36
Show 11 earlier messages
-
Frank Nägler uploaded patch set 1 12/09/14, 19:46
-
Frank Nägler commented on patch set 1 CR -1 12/09/14, 20:08
on it -
Wouter Wolters commented on patch set 1 CR -1 12/09/14, 20:11
AjaxDataHandler.js:55the removeClass call here is already done on line 40 isn;t it?AjaxDataHandler.js:87space missing before {AjaxDataHandler.js:88; missing at the end of the line?AjaxDataHandler.js:111put displaying flahmessages in a private method hereAjaxDataHandler.js:116$iconElement.addClass(elementClass); Can be done outside the if and elseAjaxDataHandler.js:122maybe put refreshing also in a private method?DatabaseRecordList.php:1318$params) .'" < space missing here -
Frank Nägler commented on patch set 1 12/09/14, 20:17
AjaxDataHandler.js:87ReplyDoneAjaxDataHandler.js:88ReplyDoneAjaxDataHandler.js:111ReplyDoneAjaxDataHandler.js:116ReplyDoneAjaxDataHandler.js:122ReplyDoneDatabaseRecordList.php:1318ReplyDone -
Frank Nägler uploaded patch set 2 12/09/14, 22:24
-
Mathias Brodala commented on patch set 2 12/10/14, 08:17
Just for the record: it'd be awesome if there was no confirmation at all. Instead the record is deleted immediately and a notification message shown which contains a link to undo the delete. But maybe that's something for a following change. -
Frank Nägler commented on patch set 2 12/10/14, 08:51
nice idea, but please let us discuss this first and implement it in a second patch. -
Andreas Kienast commented on patch set 2 CR -1 12/10/14, 09:04
AjaxDataHandler.js:79Please store this in a variable (var $me = $(this)), there's no need to interate the dom multiple times.AjaxDataHandler.js:80same hereAjaxDataHandler.js:92.modal-footer is imo superfluous, an ID must be unique. -
Frank Nägler commented on patch set 2 12/10/14, 17:00
AjaxDataHandler.js:79ReplyDoneAjaxDataHandler.js:80ReplyDoneAjaxDataHandler.js:92ReplyDone -
Frank Nägler uploaded patch set 3 12/10/14, 17:01
-
Frank Nägler uploaded patch set 4 12/10/14, 17:02
-
Frank Nägler commented on patch set 4 CR -1 12/10/14, 17:05
on it -
Frank Nägler uploaded patch set 5 12/10/14, 17:30
-
Frank Nägler commented on patch set 5 CR -1 12/10/14, 17:31
-1 until the layout for the modal is verified by UX Team -
Felix Kopp commented on patch set 5 12/12/14, 12:12
Hi Guys, just that I am not the blocker here quick summary from my side. I see the immense need to add a central Modal JS API to the core that delivers modals not only in one module but via BackenController. Please also see https://forge.typo3.org/issues/62334 and idea to add the modal DIV to BackendController as in https://github.com/7elix/TYPO3.CMS.Flat/blob/master/Classes/Controller/BackendController.php. The scope of the Modal API should be display Confirm box with call-back/return and load iFrame / AJAX content. In the long run I personally would like to bring the user settings into this modal and also edit view (BK disagreed currently) - in order to pop these views out of the normal workflow within backend modules. Frank, would you like to create a BluePrint for an early version of this Modal API and collect best practise examples? THANKS! -
Frank Nägler commented on patch set 5 12/12/14, 12:18
Hey Felix, many thanks for your feedback! As I remember from the code sprint in Hamburg, the modals should be used rarely, but I agree, backend JS API for modals could be very nice. I will contact "BK" ;) And will follow up this issue. -
Frank Nägler uploaded patch set 6 12/23/14, 21:38
-
Stefan Neufeind commented on patch set 6 V -1 CR +1 12/23/14, 21:51
Looks nice, but there are some minor things: * deleting an element does not decrease the count on top of the list * trying to delete a page from listview which has sub-pages (and recursive delete off) fails. But don't we want to display some error then? -
Stefan Neufeind commented on patch set 6 12/23/14, 21:53
Should we maybe have "Delete" be the default-action? I somehow feel that pressing enter to confirm or esc to abort is a common usecase. Since Cancel is the default, pressing enter currently cancels. -
Frank Nägler commented on patch set 6 12/23/14, 21:58
imo no, delete should not be the default button to prevent accidentally deleting of records. -
Frank Nägler uploaded patch set 7 01/04/15, 17:14
-
Frank Nägler commented on patch set 7 01/04/15, 17:15
- fixed delete on pages which has subpages and show message. - change count of items in table header -
Frank Nägler uploaded patch set 8 01/04/15, 17:39
-
Benjamin Kott voted on patch set 8 CR +1 V +1 01/04/15, 17:48
-
Benni Mack uploaded patch set 9 01/04/15, 18:08
-
Frank Nägler commented on patch set 9 V -1 01/04/15, 18:12
on it again -
Frank Nägler uploaded patch set 10 01/04/15, 18:31
-
Frank Nägler commented on patch set 10 01/04/15, 18:32
Added: - remove panel after last row was removed - use JS translate function for button text instead of adding HTML data attribute in each row. -
Stefan Froemken commented on patch set 10 01/04/15, 19:38
This Feature does not work in FF. -
Frank Nägler commented on patch set 10 01/04/15, 19:53
it is developed in FF and tested in chrome, safari and FF. can you provide more information? maybe your browser cache? -
Benni Mack voted on patch set 10 CR +1 01/04/15, 19:57
-
Stefan Froemken commented on patch set 10 V +1 01/04/15, 20:10
Sorry. Shift+Cmd+r seems not to be enough. After opening dev-Tools it works. -
Benni Mack voted on patch set 10 V +2 01/04/15, 20:14
-
Benjamin Kott voted on patch set 10 CR +1 V +1 01/04/15, 20:15
-
Benni Mack voted on patch set 10 CR +2 01/04/15, 20:20
-
Benni Mack merged patch set 10 01/04/15, 20:20