Review main Merged

35339[BUGFIX] Fixes position of suggest wizzard autocomplete result in IE

Torben Hansen CR +2 V +2 Easy +2 −2 updated 01/05/15, 12:42

Commit message

A 5 years old bug in script.aculo.us leads to the problem, that
autocomplete results of the suggest wizzard are displayed at a
wrong position for Internet Explorer browsers. Depending on the
screen resolution, the autocomplete results may even be out of the
visual area of the users screen.

Since script.aculo.us seems to be unmaintained, the patch is directly
applied to the script.aculo.us source files, so we at least can
provide a bugfix for TYPO3 users using Internet Explorer.

This patch also fixes an IE fix in script.aculo.us. Instead of using
javascript:false we now use about:blank as source for the IE fix
iframe, which prevents the text “false” being displayed when
autocompletion results appear in IE.

Review

  • Code review CR +2
    • Markus Klein +2
    • Mathias Schreiber +1
  • Verified V +2
    • Markus Klein +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 6

  1. Torben Hansen uploaded patch set 1 12/12/14, 09:52

  2. Mathias Schreiber wrote 12/17/14, 20:36

    Topic set to 3rd Party
  3. Mathias Schreiber voted on patch set 1 CR +1 V +1 01/05/15, 09:09

  4. Markus Klein voted on patch set 1 CR +2 V +2 01/05/15, 12:42

  5. Markus Klein merged patch set 1 01/05/15, 12:42

  6. Markus Klein commented on patch set 2 01/05/15, 12:42

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 3e2afc8e430ae58fc6bf339e711c950d2f59c508