35365[TASK] Add unit tests for mergeRecursiveWithOverrule
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Stephan Großberndt +1
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Stephan Großberndt +1
- Anja Leichsenring +1
Issues 1
Files 1
Review log 13
-
Markus Klein uploaded patch set 1 12/12/14, 17:08
-
Markus Klein uploaded patch set 2 12/12/14, 17:19
-
Markus Klein commented on patch set 2 12/12/14, 17:24
-
Markus Klein voted on patch set 2 V -1 12/12/14, 17:25
-
Anja Leichsenring commented on patch set 2 CR -1 12/14/14, 08:38
ArrayUtilityTest.php:1522ReplyI don't understand the usecase. Why should you call on a array_merge function and expect a string to come back??? -
Markus Klein commented on patch set 2 12/14/14, 12:34
ArrayUtilityTest.php:1522ReplyThe usecase would be that you have some huge nested array and at some point in this array you want to overwrite an entry (which is an array in the original input) with a plain string. As discussed with Christian yesterday, we will add a note to the function that this is currently not working. Maybe we can consider adding this specific case, but generally the usage of the method should be avoided anyways if you do not need the __UNSET feature. One should go for the native PHP functions for this functionality. -
Anja Leichsenring commented on patch set 2 CR 0 12/14/14, 12:52
okay, fine with me. -
Christian Kuhn uploaded patch set 3 12/16/14, 20:29
-
Christian Kuhn commented on patch set 3 CR +1 V +1 12/16/14, 20:33
Hope I catched main functionality of this method now ;) -
Anja Leichsenring voted on patch set 3 CR +1 V +1 12/16/14, 20:36
-
Stephan Großberndt voted on patch set 3 CR +1 V +1 12/16/14, 22:14
-
Christian Kuhn voted on patch set 3 CR +2 V +2 12/16/14, 22:14
-
Christian Kuhn merged patch set 3 12/16/14, 22:14
ArrayUtilityTest.php:1522