Review main Merged

35388[TASK] Use better implementation for array check

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 12/13/14, 19:06

Commit message

To suppress PHP warnings the input parameter must always be an array.
If there is nothing to merge, the array_merge_overrule function
must not be called at all.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Helmut Hummel +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 7

  1. Anja Leichsenring uploaded patch set 1 12/13/14, 14:49

  2. Benni Mack voted on patch set 1 CR +1 12/13/14, 14:52

  3. Stephan Großberndt updated the commit message in patch set 2 12/13/14, 14:53

  4. Helmut Hummel voted on patch set 2 CR +2 12/13/14, 15:15

  5. Christian Kuhn voted on patch set 2 CR +2 V +2 12/13/14, 19:03

  6. Christian Kuhn merged patch set 2 12/13/14, 19:06

  7. Christian Kuhn commented on patch set 3 12/13/14, 19:06

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit f2f52826e8de3b104cc6cc246bafb8c62057d4fe