Review main Merged

35399[BUGFIX] Fix "Enable tab" for textareas inside inline elements

Georg Ringer CR +2 V +2 Easy +2 −0 updated 12/14/14, 17:05

Commit message

If a field is configured in the TCA by using
"'defaultExtras' => 'fixed-font : enable-tab'", the textarea
behaves different (pressing the tab produces a tab).

Since inline elements use AJAX, the js method which changes the behaviour
of the textarea needs to be reapplied.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 7

  1. Georg Ringer uploaded patch set 1 12/13/14, 19:11

  2. Christian Kuhn commented on patch set 1 CR -1 12/13/14, 19:16

    please create an example in ext:styleguide - https://github.com/7elix/TYPO3.CMS.Styleguide - to show this behavior. this will also take care that it does not break later again.
  3. Georg Ringer commented on patch set 1 12/13/14, 19:34

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 12/13/14, 20:08

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 12/14/14, 17:05

  6. Christian Kuhn merged patch set 1 12/14/14, 17:05

  7. Christian Kuhn commented on patch set 2 12/14/14, 17:05

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 81009f9cc0560d9d0eddfcf597ab494257fb1b72