Review main Merged

35407[BUGFIX] Fix image rendering for renderMethod = table

Torben Hansen CR +2 V +2 Easy +17 −1 updated 01/01/15, 18:45

Commit message

Since the introduction of FAL to TYPO3, the rendering of images
using CSS styled content with renderMethod = table is broken.

Using a single image results in the image being rendered twice
and if you have multiple images in one content object, only the
last image is rendered multiple times (depending on the amount
of images in the content object).

This patch resolves both issues and loads the current image file
reference to the contentObjectRenderer while looping through the
images of the content object.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1

Issues 2

Files 1

Review log 12

  1. Torben Hansen uploaded patch set 1 12/14/14, 12:06

  2. Anja Leichsenring updated the commit message in patch set 2 12/14/14, 12:09

  3. Anja Leichsenring commented on patch set 2 12/14/14, 12:11

    ImageTextContentObject.php:485

    make this a class property loaded only once?
  4. Torben Hansen commented on patch set 2 12/14/14, 12:19

    ImageTextContentObject.php:485 Reply

    I just saw, that ResourceFactory is actually available in the abstract class so I'm going to use that instance.
  5. Torben Hansen uploaded patch set 3 12/14/14, 12:20

  6. Anja Leichsenring voted on patch set 3 CR +1 12/14/14, 12:50

  7. Benni Mack voted on patch set 3 CR +1 12/14/14, 17:50

  8. Mathias Schreiber wrote 12/17/14, 20:36

    Topic set to cObj
  9. Benni Mack voted on patch set 3 V +1 12/30/14, 15:41

  10. Wouter Wolters voted on patch set 3 V +2 CR +2 01/01/15, 18:45

  11. Wouter Wolters merged patch set 3 01/01/15, 18:45

  12. Wouter Wolters commented on patch set 4 01/01/15, 18:45

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 6501bfde7abc6d6876c84a1a35bbb64f7520d67d