Review main Merged

35429[CLEANUP] Add htmlspecialchars in some form elements

Frank Nägler CR +2 V +2 Easy +11 −12 updated 05/01/15, 15:52

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Jan Helke +1
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Jan Helke +1

Issues 1

Files 5

Review log 26

Show 1 earlier messages
  1. Frank Nägler uploaded patch set 1 12/14/14, 16:55

  1. Mathias Schreiber wrote 12/17/14, 14:33

    Topic set to Formengine
  2. Wouter Wolters voted on patch set 1 CR +1 01/02/15, 11:04

  3. Frank Nägler wrote 01/22/15, 10:40

    Topic changed from Formengine to FormEngine
  4. Mathias Brodala commented on patch set 1 CR -1 01/22/15, 15:20

    CheckboxElement.php:73

    No need to escape these known values too.
  5. Christian Kuhn commented on patch set 1 03/02/15, 19:47

    anyone wants to have a look and rebase?
  6. Helmut Hummel commented on patch set 1 03/02/15, 19:54

    CheckboxElement.php:73 Reply

    I disagree! From reading this code location it is not clear whether is safe or not.
  7. Mathias Brodala commented on patch set 1 CR +1 03/03/15, 07:32

    CheckboxElement.php:73 Reply

    Done

    CheckboxElement.php:73 Reply

    Done
  8. Oliver Klee commented on patch set 1 03/03/15, 10:10

    InputElement.php:4

    This change does not seem related.
  9. Frank Nägler uploaded patch set 2 03/12/15, 20:02

  10. Frank Nägler commented on patch set 2 03/12/15, 20:03

    only rebase
  11. Markus Klein commented on patch set 2 CR +1 V +1 03/12/15, 23:33

    looks good now
  12. Michael Oehlhof voted on patch set 2 CR +1 03/15/15, 16:02

  13. Stephan Großberndt voted on patch set 2 CR +1 03/15/15, 16:03

  14. Markus Klein commented on patch set 2 CR -2 03/15/15, 16:05

    blocked until lolli finished FormEngine work
  15. Frank Nägler commented on patch set 2 03/15/15, 16:13

    your are right Markus, thx! I am fine with that.
  16. Markus Klein commented on patch set 2 04/16/15, 22:20

    The patch I referred to is: https://review.typo3.org/38433
  17. Frank Nägler uploaded patch set 3 05/01/15, 13:28

  18. Frank Nägler commented on patch set 3 05/01/15, 13:28

    rebased, @Markus: please remove your vote, the FormEngine patch is merged.
  19. Markus Klein voted on patch set 3 CR 0 05/01/15, 13:49

  20. Markus Klein voted on patch set 3 CR +1 V +1 05/01/15, 13:50

  21. Christian Kuhn voted on patch set 3 CR +1 05/01/15, 14:10

  22. Christian Kuhn commented on patch set 3 05/01/15, 14:10

    jan will test soon.
  23. Jan Helke voted on patch set 3 CR +1 V +1 05/01/15, 14:31

  24. Markus Klein voted on patch set 3 CR +2 V +2 05/01/15, 15:52

  25. Markus Klein merged patch set 3 05/01/15, 15:52