35429[CLEANUP] Add htmlspecialchars in some form elements
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Jan Helke +1
- Christian Kuhn +1
-
Verified V +2
- Markus Klein +2
- Jan Helke +1
Issues 1
Files 5
- typo3/sysext/backend/Classes/Form/Element/CheckboxElement.php4+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputElement.php1+2 −2
- typo3/sysext/backend/Classes/Form/Element/SelectElement.php+3 −3
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizard.php+3 −4
Review log 26
Show 1 earlier messages
-
Frank Nägler uploaded patch set 1 12/14/14, 16:55
-
Mathias Schreiber wrote 12/17/14, 14:33
Topic set to Formengine -
Wouter Wolters voted on patch set 1 CR +1 01/02/15, 11:04
-
Frank Nägler wrote 01/22/15, 10:40
Topic changed from Formengine to FormEngine -
Mathias Brodala commented on patch set 1 CR -1 01/22/15, 15:20
CheckboxElement.php:73No need to escape these known values too. -
Christian Kuhn commented on patch set 1 03/02/15, 19:47
anyone wants to have a look and rebase? -
Helmut Hummel commented on patch set 1 03/02/15, 19:54
CheckboxElement.php:73ReplyI disagree! From reading this code location it is not clear whether is safe or not. -
Mathias Brodala commented on patch set 1 CR +1 03/03/15, 07:32
CheckboxElement.php:73ReplyDoneCheckboxElement.php:73ReplyDone -
Oliver Klee commented on patch set 1 03/03/15, 10:10
InputElement.php:4This change does not seem related. -
Frank Nägler uploaded patch set 2 03/12/15, 20:02
-
Frank Nägler commented on patch set 2 03/12/15, 20:03
only rebase -
Markus Klein commented on patch set 2 CR +1 V +1 03/12/15, 23:33
looks good now -
Michael Oehlhof voted on patch set 2 CR +1 03/15/15, 16:02
-
Stephan Großberndt voted on patch set 2 CR +1 03/15/15, 16:03
-
Markus Klein commented on patch set 2 CR -2 03/15/15, 16:05
blocked until lolli finished FormEngine work -
Frank Nägler commented on patch set 2 03/15/15, 16:13
your are right Markus, thx! I am fine with that. -
Markus Klein commented on patch set 2 04/16/15, 22:20
The patch I referred to is: https://review.typo3.org/38433 -
Frank Nägler uploaded patch set 3 05/01/15, 13:28
-
Frank Nägler commented on patch set 3 05/01/15, 13:28
rebased, @Markus: please remove your vote, the FormEngine patch is merged. -
Markus Klein voted on patch set 3 CR 0 05/01/15, 13:49
-
Markus Klein voted on patch set 3 CR +1 V +1 05/01/15, 13:50
-
Christian Kuhn voted on patch set 3 CR +1 05/01/15, 14:10
-
Christian Kuhn commented on patch set 3 05/01/15, 14:10
jan will test soon. -
Jan Helke voted on patch set 3 CR +1 V +1 05/01/15, 14:31
-
Markus Klein voted on patch set 3 CR +2 V +2 05/01/15, 15:52
-
Markus Klein merged patch set 3 05/01/15, 15:52