35442[!!!][TASK] Deprecate stdWrap options textStyle, tableStyle
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
Issues 1
Files 2
Review log 12
-
Georg Ringer uploaded patch set 1 12/14/14, 19:44
-
Wouter Wolters commented on patch set 1 12/14/14, 20:24
-
Georg Ringer uploaded patch set 2 12/14/14, 21:06
-
Wouter Wolters voted on patch set 2 V +1 CR +1 12/14/14, 21:08
-
Christian Kuhn commented on patch set 2 12/14/14, 21:15
raising the question from forge here again: Just a question, maybe silly,but...what if someone wants to add a javascript-related "data-stuff" attribute? page.10 = TEXT page.10.value = <div> page.10.addParams.data-something = true -
Christian Kuhn commented on patch set 2 CR -1 12/14/14, 21:25
it looks like as if addParams is still used in the core at least in AbstractMenuContentObject.php -
Mathias Brodala commented on patch set 2 12/15/14, 08:30
@Christian: Not really a good example. What prevents you from writing page.10.value = <div data-something="true">? ;-) -
Georg Ringer uploaded patch set 3 12/15/14, 18:41
-
Markus Klein voted on patch set 3 CR +1 V +1 12/15/14, 18:51
-
Christian Kuhn voted on patch set 3 CR +2 V +2 12/15/14, 19:22
-
Christian Kuhn merged patch set 3 12/15/14, 19:22
-
Benni Mack commented on patch set 4 01/20/15, 21:35
could you do a followup on this one? Also make sure that the stdWrap_* (e.g. stdWrap_textStyle()) method is marked for deprecation - and also we should deprecate stdWrap.fontTag and stdWrap.wrapAlign along with it. What do you think?
Deprecation-49247-textStyleTableStyleAddParams.rst:2