Review main Merged

35496[BUGFIX] Unreadable directories must not crash filemount storages

Georg Ringer CR +2 V +2 Easy +5 −1 updated 12/16/14, 13:00

Commit message

If a *single* directory in the fileadmin tree can't be read, the whole
select box of the file mounts is empty.

Just hide the entry which is not readable

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Mathias Schreiber +1
    • Frans Saris +1
  • Verified V +2
    • Alexander Opitz +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 8

  1. Georg Ringer uploaded patch set 1 12/15/14, 19:29

  2. Frans Saris voted on patch set 1 CR +1 12/15/14, 19:46

  3. Wouter Wolters commented on patch set 1 12/15/14, 19:49

    UserFileMountService.php:120

    space after catch
  4. Mathias Schreiber voted on patch set 1 CR +1 V +1 12/15/14, 19:50

  5. Alexander Opitz commented on patch set 1 CR -1 12/16/14, 12:49

    Will take a look.
  6. Alexander Opitz commented on patch set 1 V +2 CR +2 12/16/14, 12:58

    Fine, it seams I forgot to write an issue as I discovered this.
  7. Alexander Opitz merged patch set 1 12/16/14, 12:58

  8. Alexander Opitz commented on patch set 2 12/16/14, 13:00

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 3dd7595c48fdbfd55159adbfa816c10cddf7416a