35506[FEATURE] Support maximum length in TextElement
Commit message
Review
-
Code review CR +2
- Alexander Opitz +2
- Andreas Kienast +1
- Mathias Brodala +1
-
Verified V +2
- Alexander Opitz +2
- Andreas Kienast +1
Issues 1
Files 2
Review log 13
-
Georg Ringer uploaded patch set 1 12/16/14, 06:48
-
Georg Ringer uploaded patch set 2 12/16/14, 07:13
-
Andreas Kienast voted on patch set 2 CR +1 V +1 12/16/14, 07:15
-
Mathias Brodala commented on patch set 2 CR -1 12/16/14, 07:55
maximum length"max" option for specifying a maximum lengthFeature-24906-MaxForTextElement.rst:20single quotes -
Georg Ringer uploaded patch set 3 12/16/14, 08:18
-
Alexander Opitz voted on patch set 3 V +1 CR +1 12/16/14, 08:24
-
Andreas Kienast voted on patch set 3 CR +1 V +1 12/16/14, 08:30
-
Mathias Brodala voted on patch set 3 CR +1 12/16/14, 08:45
-
Alexander Opitz voted on patch set 3 V +2 CR +2 12/16/14, 10:17
-
Alexander Opitz merged patch set 3 12/16/14, 10:17
-
Christian Kuhn commented on patch set 4 12/16/14, 14:02
hey. i wonder why this went in so smooth - i just added an example to ext:styleguide to show this feature, and stumbled upon the following: * First and foremost, this is an html5 feature that is not supported by all browsers yet. For example IE9 doesn't have that. * My chromium seems to count a linebreak as 2 characters. So, if I add content in 3 lines with a max of 30, only 26 printed characters are possible. No idea on other browsers, though. I'm fine with keeping this patch, but I'd at least expect a follow-up to improve the .rst file hinting for these details. -
Andreas Kienast commented on patch set 4 12/19/14, 07:21
> * First and foremost, this is an html5 feature that is not > supported by all browsers yet. For example IE9 doesn't have that. As written here [1], I'm fine with this change as we support HTML5 features with CMS7. Also, currently at least IE 10 is required due to our CSS issues. [1] http://wiki.typo3.org/TYPO3.CMS/Protocols/T3ACME14MUC > * My chromium seems to count a linebreak as 2 characters I guess it's because how a line break is represented. It's a carriage return (\r\n) [2], which are obviously two character. [2] http://stackoverflow.com/questions/10030921/chrome-counts-characters-wrong-in-textarea-with-maxlength-attribute -
Christian Kuhn commented on patch set 4 12/19/14, 10:31
Yes, I only want that something like that is reflected in the .rst file, so the documentation will later have some information about this behavior. This was not obvious to me and so may be for others.