Review main Merged

35527[CLEANUP] Add missing empty lines before classes' closing curly braces

mostwanted CR -1 V +2 Hard +908 −0 updated 12/16/14, 23:29

Commit message

Most of TYPO3's PHP files have an empty line before a class' closing curly
brace. This commit adds this empty line (if it is missing) before a class'
closing curly brace.

This is not part of the TYPO3 CMS CGL but increases consistency in this
area.

This regular expression was used to add the empty lines:

Search:
(}\n)(})

Replace:
$1\n$2

Review

  • Code review CR -1
    • Christian Kuhn +2
    • mostwanted -1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 909

Show 889 more files

Review log 4

  1. mostwanted uploaded patch set 1 12/16/14, 22:42

  2. mostwanted commented on patch set 1 CR -1 12/16/14, 22:54

    This commit conflicts with 13 other change requests. I guess it does not make sense to increase the workload in those more important 13 change requests. Therefore I think it will be better to not merge this commit but wait until it is not conflicting with so many other change requests any longer. I will rebase this commit from time to time and will ask for review/merge when it does not conflict with other change requests if this is ok for you. Otherwise I am also ok to abandon this commit completely.
  3. Christian Kuhn commented on patch set 1 CR +2 V +2 12/16/14, 23:29

    Hey Roland. You're right, this patch is not *that* important, and it also breaks some other ones. Also, I don't care too much about consistency in core classes for details like this. OTOH, this patch is pending now, and a main cleanup in this area in not really bad, even if I'd not nitpick about this or would -1 a patch because of a missing empty line. However, now we have this pending here, and id does not really make sense to have it hanging around, either. I hope this is one of the last systematic changes like this in this area ... Read through it now, looks good, get it done, merged.
  4. Christian Kuhn merged patch set 1 12/16/14, 23:29