Review main Merged

35531[BUGFIX] Fix fatal in RsaAuth-PhpBackendTest with broken openssl config

Stephan Großberndt CR +2 V +2 Easy +7 −5 updated 12/18/14, 22:05

Commit message

If the openssl environment is not set up correctly (in Install Tool:
"PHP OpenSSL extension not working") the unit test
TYPO3\CMS\Rsaauth\Tests\Unit\Backend\PhpBackendTest causes a fatal PHP
error "Call to a member function isReady() on a non-object". This
happens because $this->subject->createNewKeyPair() returns NULL if
something goes wrong while setting up a openssl keypair.

Assert the keypair is not null before calling $keypair->isReady().

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stephan Großberndt +1
  • Verified V +2
    • Christian Kuhn +2
    • Stephan Großberndt +1

Issues 1

Files 1

Review log 10

  1. Stephan Großberndt uploaded patch set 1 12/17/14, 01:21

  2. Christian Kuhn commented on patch set 1 12/17/14, 11:17

    PhpBackendTest.php:39

    while we usually don't do this, for this specific case i think its a good idea to use the next parameter "message", stating something like "your env is broken, not the code therfore the test fail!"
  3. Stephan Großberndt uploaded patch set 2 12/17/14, 13:53

  4. Mathias Schreiber wrote 12/17/14, 14:33

    Topic set to EXT: rsaauth
  5. Christian Kuhn uploaded patch set 3 12/18/14, 18:04

  6. Christian Kuhn commented on patch set 3 CR +1 V +1 12/18/14, 18:04

    minor text change.
  7. Oliver Klee voted on patch set 3 CR +1 12/18/14, 18:44

  8. Stephan Großberndt voted on patch set 3 CR +1 V +1 12/18/14, 21:10

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 12/18/14, 22:05

  10. Christian Kuhn merged patch set 3 12/18/14, 22:05