Review main Abandoned

35551[FEATURE] Add a "typeClass" CSS class to typolinks

Christian Futterlieb CR 0 V 0 Normal +190 −0 updated 01/19/15, 07:57

Commit message

Add the possibility to define an additional CSS class for every typolink,
which can be useful for web analytics purposes.

The feature can be enabled with config.typolinkTypeClassEnable = 1

The specific "typeClasses" can be defined once globally with:
config.typolinkTypeClass {
    mailto = class-for-email-links
    page = class-for-page-links
    url = class-for-url-links
    file = class-for-file-links
}

It is possible to disable the "typeClass" per typolink with:
typolink.typeClassDisable = 1
which is a boolean/stdWrap

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 11

  1. Christian Futterlieb uploaded patch set 1 12/17/14, 21:19

  2. Christian Futterlieb uploaded patch set 2 12/17/14, 21:40

  3. Mathias Brodala commented on patch set 2 CR -1 12/17/14, 22:10

    I don't like this approach in general since it seems way too limited. What about completely new types we don't even know yet? This should at least use some kind of registry.

    TypoScriptFrontendController.php:461

    Please don't clutter the controller more than it already is and add at least proper getter/setter methods.

    TypoScriptFrontendController.php:468

    Same here

    TypoScriptFrontendController.php:475

    Same here

    TypoScriptFrontendController.php:482

    Same here

    TypoScriptFrontendController.php:489

    Same here

    PageGenerator.php:80

    See my comments wrt proper setter/getters.
  4. Markus Klein commented on patch set 2 CR -1 12/17/14, 22:59

    Fully agree with Mathias! This needs a proper concept. Defining default typolink options on global config level seems strange somehow.
  5. Christian Futterlieb uploaded patch set 3 12/17/14, 23:18

  6. Christian Futterlieb commented on patch set 3 12/17/14, 23:24

    @Mathias: is this more open-aproach? @Markus: Looking at intTarget and extTarget, which are global typolink definitions too, made me think of such a feature.. If a more proper concept is needed, those options should go in there too. What do you think?
  7. Markus Klein commented on patch set 3 12/17/14, 23:25

    Please don't invest more time in this patch. Get in touch with others in slack and discuss your idea first. Thanks
  8. Christian Futterlieb commented on patch set 3 12/17/14, 23:44

    Ok, how to get there, do I need an invitation? Or is it sufficient to write to typo3.core mailing list? Thanks in advance!
  9. Anja Leichsenring commented on patch set 3 12/21/14, 17:22

    hi, sorry for the late reply: Currently there is a limitation of Slack being "invite only", but this is only a technical limitation. If you work with or for TYPO3, consider joining it by asking for an access to admin@typo3.org. Give them your e-mail address, forge user account name and wait for your account to be created. Then join http://typo3.slack.com/ and our channel #typo3-cms.
  10. Anja Leichsenring abandoned the change 01/18/15, 13:00

    I abandon this patch now, as it does not solve the issue in the way the core requires. The according ticket will stay open, we need to provide a satisfying solution. Please join the effort in Slack and thank you for the contribution.
  11. Christian Futterlieb commented on patch set 3 01/19/15, 07:57

    Sorry for staying calm that long. Now with a bit more distance I see that this approach is not very elaborated :D Thanks for you work anyway!