Review TYPO3_6-2 Merged

35597[BUGFIX] Fix fatal in RsaAuth-PhpBackendTest with broken openssl config

Christian Kuhn CR +2 V +2 Easy +7 −4 updated 12/20/14, 09:43

Commit message

If the openssl environment is not set up correctly (in Install Tool:
"PHP OpenSSL extension not working") the unit test
TYPO3\CMS\Rsaauth\Tests\Unit\Backend\PhpBackendTest causes a fatal PHP
error "Call to a member function isReady() on a non-object". This
happens because $this->subject->createNewKeyPair() returns NULL if
something goes wrong while setting up a openssl keypair.

Assert the keypair is not null before calling $keypair->isReady().

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 3

  1. Christian Kuhn uploaded patch set 1 12/20/14, 09:43

  2. Christian Kuhn voted on patch set 1 CR +2 V +2 12/20/14, 09:43

  3. Christian Kuhn merged patch set 1 12/20/14, 09:43