Review main Merged

35601[FEATURE] Add pattern attribute to TextfieldViewHelper

Roman Schürmann CR +2 V +2 Easy +1 −0 updated 12/20/14, 16:11

Commit message

In order to allow HTML5 validation, the Textfield ViewHelper needs
"pattern" as an attribute.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Mathias Schreiber +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 6

  1. Roman Schürmann uploaded patch set 1 12/20/14, 15:27

  2. Roman Schürmann uploaded patch set 2 12/20/14, 15:30

  3. Mathias Schreiber commented on patch set 2 CR +1 V +1 12/20/14, 15:31

    that's so no-brain...
  4. Frank Nägler voted on patch set 2 V +1 CR +1 12/20/14, 16:10

  5. Frank Nägler voted on patch set 2 V +2 CR +2 12/20/14, 16:11

  6. Frank Nägler merged patch set 2 12/20/14, 16:11