Review main Merged

35614[BUGFIX] Ensure salted passwords are written to DB

Markus Klein CR +2 V +2 Easy +18 −13 updated 01/30/15, 11:24

Commit message

Ensure that salted passwords are written to DB also when importing
data from t3d files.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Nils Heuermann +1
  • Verified V +2
    • Benni Mack +2
    • Nils Heuermann +1

Issues 1

Files 3

Review log 18

  1. Markus Klein uploaded patch set 1 12/21/14, 14:21

  2. Markus Klein commented on patch set 1 12/21/14, 14:22

    UNTESTED
  3. Markus Klein wrote 12/23/14, 23:37

    Topic set to Datahandler
  4. Markus Klein uploaded patch set 2 12/23/14, 23:47

  5. Markus Klein updated the commit message in patch set 3 12/23/14, 23:47

  6. Markus Klein commented on patch set 3 12/23/14, 23:47

    Changing the password in BE still works.
  7. Nils Heuermann commented on patch set 3 CR +1 01/05/15, 16:02

    I tested the change and it works for me: The password is imported from t3d and is also encoded when changing the password in the backend form. Though after checking out this patch set, I had to adjust the ext_localconf.php and TCA Override files to match the namespaced class name of the evaluators: TYPO3\\CMS\\Saltedpasswords\\Evaluation\\FrontendEvaluator instead of tx_saltedpasswords_eval_fe TYPO3\\CMS\\Saltedpasswords\\Evaluation\\BackendEvaluator instead of tx_saltedpasswords_eval_be
  8. Markus Klein commented on patch set 3 01/05/15, 16:06

    Thanks for testing, Nils. I guess you tested that on 6.2. The code in master is already fully namespaced, so you need to install the compatibility6 extension in order to get the old class names back.
  9. Nils Heuermann commented on patch set 3 01/06/15, 08:41

    As far as I can see the old class names in the configuration are still used in master. I filed an issue and submitted a patch set for it: https://forge.typo3.org/issues/64140
  10. Benni Mack commented on patch set 3 01/20/15, 06:34

    Evaluator.php:50

    this is always bool now, right?
  11. Markus Klein commented on patch set 3 01/20/15, 07:35

    Evaluator.php:50 Reply

    Right, bool only. Will fix that
  12. Markus Klein uploaded patch set 4 01/20/15, 07:37

  13. Wouter Wolters voted on patch set 4 CR +1 01/20/15, 22:57

  14. Nils Heuermann voted on patch set 4 CR +1 V +1 01/21/15, 07:47

  15. Benni Mack voted on patch set 4 CR +1 01/22/15, 17:57

  16. Benni Mack voted on patch set 4 CR +2 01/22/15, 17:57

  17. Benni Mack voted on patch set 4 V +2 01/30/15, 11:24

  18. Benni Mack merged patch set 4 01/30/15, 11:24