Review main Merged

35621[BUGFIX] EXT:form: Make hardcoded messages translatable

Michael Oehlhof CR +2 V +2 Easy +32 −17 updated 04/04/15, 19:25

Commit message

After saving a form, we can see the "Changes saved successfully"
or "Failed to save the form" message boxes.

These messages were hardcoded and are now available in the
locallang_wizard.xlf file.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Markus Klein +1
  • Verified V +2
    • Frank Nägler +2
    • Markus Klein +1

Issues 1

Files 5

Review log 18

  1. Michael Oehlhof uploaded patch set 1 12/23/14, 02:14

  2. Markus Klein commented on patch set 1 12/23/14, 10:10

    Thanks for the patch. Just some small nitpicks.
    Please describe what the change is doing. You describe the bug, which is already described in forge. Suggestion: [BUGFIX] form: Make hardcoded messages translatable
    Lines too long. Keep it below 74 chars please

    AbstractWizardView.php:50

    While you're touching this. Please create a getLanguageService() method to wrap the access to the global. We started doing so all over the core now.
  3. Michael Oehlhof uploaded patch set 2 12/23/14, 11:33

  4. Oliver Klee voted on patch set 2 CR +1 12/23/14, 12:27

  5. Stefan Neufeind commented on patch set 2 12/23/14, 19:08

    SaveWizardView.php:51

    Should this really be TRUE? Or do we maybe want the values without html-escaping for the moment? They are json-encoded below - and I expect they might get escaped if need be before they are actually displayed - not?
  6. Michael Oehlhof uploaded patch set 3 12/26/14, 17:17

  7. Michael Oehlhof commented on patch set 2 12/26/14, 17:21

    I'm fighting with git, my actual changes are not in the Patch. Will update the patch again.
  8. Michael Oehlhof uploaded patch set 4 12/26/14, 19:08

  9. Mathias Schreiber wrote 01/02/15, 17:31

    Topic set to EXT: form
  10. Michael Oehlhof updated the commit message in patch set 5 02/27/15, 21:02

  11. Stefan Neufeind commented on patch set 5 CR -1 02/27/15, 21:07

    WizardView.php:97

    if we don't includeLL the file above, then I guess you have to give the full EXT:form/... here?

    WizardView.php:350

    full EXT:form/... here as well?
  12. Michael Oehlhof commented on patch set 5 02/28/15, 00:41

    WizardView.php:97 Reply

    The xlf file is already loaded in loadLocalization(), so line 63 could be removed.
  13. Stefan Neufeind commented on patch set 5 CR +1 02/28/15, 07:27

    Okay thanks. Makes sense by reading then.
  14. Markus Klein voted on patch set 5 CR +1 03/27/15, 17:56

  15. Markus Klein uploaded patch set 6 03/30/15, 23:04

  16. Markus Klein voted on patch set 6 CR +1 V +1 03/30/15, 23:05

  17. Frank Nägler voted on patch set 6 V +2 CR +2 04/04/15, 19:25

  18. Frank Nägler merged patch set 6 04/04/15, 19:25