35621[BUGFIX] EXT:form: Make hardcoded messages translatable
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Markus Klein +1
-
Verified V +2
- Frank Nägler +2
- Markus Klein +1
Issues 1
Files 5
- typo3/sysext/form/Classes/View/Wizard/AbstractWizardView.php1+10 −0
- typo3/sysext/form/Classes/View/Wizard/LoadWizardView.php+2 −2
- typo3/sysext/form/Classes/View/Wizard/SaveWizardView.php1+3 −3
- typo3/sysext/form/Classes/View/Wizard/WizardView.php3+8 −12
- typo3/sysext/form/Resources/Private/Language/locallang_wizard.xlf+9 −0
Review log 18
-
Michael Oehlhof uploaded patch set 1 12/23/14, 02:14
-
Markus Klein commented on patch set 1 12/23/14, 10:10
Thanks for the patch. Just some small nitpicks.Please describe what the change is doing. You describe the bug, which is already described in forge. Suggestion: [BUGFIX] form: Make hardcoded messages translatableLines too long. Keep it below 74 chars pleaseAbstractWizardView.php:50While you're touching this. Please create a getLanguageService() method to wrap the access to the global. We started doing so all over the core now. -
Michael Oehlhof uploaded patch set 2 12/23/14, 11:33
-
Oliver Klee voted on patch set 2 CR +1 12/23/14, 12:27
-
Stefan Neufeind commented on patch set 2 12/23/14, 19:08
SaveWizardView.php:51Should this really be TRUE? Or do we maybe want the values without html-escaping for the moment? They are json-encoded below - and I expect they might get escaped if need be before they are actually displayed - not? -
Michael Oehlhof uploaded patch set 3 12/26/14, 17:17
-
Michael Oehlhof commented on patch set 2 12/26/14, 17:21
I'm fighting with git, my actual changes are not in the Patch. Will update the patch again. -
Michael Oehlhof uploaded patch set 4 12/26/14, 19:08
-
Mathias Schreiber wrote 01/02/15, 17:31
Topic set to EXT: form -
Michael Oehlhof updated the commit message in patch set 5 02/27/15, 21:02
-
Stefan Neufeind commented on patch set 5 CR -1 02/27/15, 21:07
WizardView.php:97if we don't includeLL the file above, then I guess you have to give the full EXT:form/... here?WizardView.php:350full EXT:form/... here as well? -
Michael Oehlhof commented on patch set 5 02/28/15, 00:41
WizardView.php:97ReplyThe xlf file is already loaded in loadLocalization(), so line 63 could be removed. -
Stefan Neufeind commented on patch set 5 CR +1 02/28/15, 07:27
Okay thanks. Makes sense by reading then. -
Markus Klein voted on patch set 5 CR +1 03/27/15, 17:56
-
Markus Klein uploaded patch set 6 03/30/15, 23:04
-
Markus Klein voted on patch set 6 CR +1 V +1 03/30/15, 23:05
-
Frank Nägler voted on patch set 6 V +2 CR +2 04/04/15, 19:25
-
Frank Nägler merged patch set 6 04/04/15, 19:25