35661[TASK] Fix common misspellings and typos
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Helmut Hummel +2
-
Verified V +2
- Wouter Wolters +2
- Helmut Hummel +2
Issues 1
Files 72
- typo3/sysext/backend/Classes/Form/Element/SuggestDefaultReceiver.php+2 −2
- typo3/sysext/backend/Classes/Form/DataPreprocessor.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+2 −2
- typo3/sysext/backend/Classes/Utility/IconUtility.php+1 −1
- typo3/sysext/backend/Classes/View/ThumbnailView.php+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/LoginRefresh.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/modulemenu.js+1 −1
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+1 −1
- typo3/sysext/context_help/4.5/locallang_csh_ttcontent.xlf+1 −1
- typo3/sysext/core/Build/FunctionalTestsBootstrap.php+1 −1
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/ApcBackend.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/SimpleFileBackend.php+1 −1
- typo3/sysext/core/Classes/Core/ClassLoader.php+3 −3
- typo3/sysext/core/Classes/Database/PreparedStatement.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −1
- typo3/sysext/core/Classes/Html/HtmlParser.php+1 −1
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+3 −3
- typo3/sysext/core/Classes/Integrity/DatabaseIntegrityCheck.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+1 −1
Show 52 more files
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ConfigurationForm.php+1 −1
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −1
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −1
- typo3/sysext/core/Documentation/Changelog/7.0/Breaking-61820-PhpOptionsUtilityDeprecatedFunctionsRemoved.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/7.0/Feature-54518-ProvideTsconfigToLinkCheckers.rst+1 −1
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+2 −2
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/TreeDataProviderFactoryTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Utility/ArrayUtilityTest.php2+3 −3
- typo3/sysext/extbase/Classes/Mvc/Controller/AbstractController.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Request.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php+1 −1
- typo3/sysext/extbase/Classes/Property/PropertyMappingConfigurationInterface.php+1 −1
- typo3/sysext/extbase/Classes/Reflection/MethodReflection.php+1 −1
- typo3/sysext/extbase/Classes/SignalSlot/Dispatcher.php+1 −1
- typo3/sysext/extbase/Classes/Utility/ArrayUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/Report/ExtensionStatus.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php+1 −1
- typo3/sysext/fluid/Classes/Core/Parser/TemplateParser.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ActionViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/PageViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+1 −1
- typo3/sysext/fluid/Tests/Unit/View/TemplateViewTest.php+2 −2
- typo3/sysext/form/Documentation/Administration/Index.rst+4 −4
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Ux/Ext.ux.spinner.js+2 −2
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php2+2 −2
- typo3/sysext/frontend/Classes/Page/FramesetRenderer.php+1 −1
- typo3/sysext/impexp/locallang_csh.xlf+1 −1
- typo3/sysext/indexed_search/Classes/Indexer.php+5 −5
- typo3/sysext/indexed_search/Documentation/Configuration/Typoscript/Index.rst+1 −1
- typo3/sysext/indexed_search/Documentation/TechnicalDetails/HowPagesAreIndexed/Index.rst+2 −2
- typo3/sysext/indexed_search/Documentation/TechnicalDetails/HtmlContent/Index.rst+2 −2
- typo3/sysext/indexed_search/locallang_csh_indexcfg.xlf+2 −2
- typo3/sysext/install/Classes/Service/SqlSchemaMigrationService.php+1 −1
- typo3/sysext/install/Classes/SystemEnvironment/Check.php+1 −1
- typo3/sysext/lang/Classes/LanguageService.php+1 −1
- typo3/sysext/lang/Resources/Public/JavaScript/LangModule.js+1 −1
- typo3/sysext/lang/locallang_core.xlf+1 −1
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+1 −1
- typo3/sysext/openid/Classes/OpenidService.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaApi.php+1 −1
- typo3/sysext/rtehtmlarea/Documentation/UsersManual/DefinitionLists/Nesting/Index.rst+1 −1
- typo3/sysext/rtehtmlarea/htmlarea/plugins/BlockElements/locallang.xlf+1 −1
- typo3/sysext/scheduler/Resources/Public/JavaScript/Scheduler.js+1 −1
- typo3/sysext/t3editor/res/tsref/tsref.xml+2 −2
Review log 10
-
Wouter Wolters uploaded patch set 1 12/28/14, 14:53
-
Wouter Wolters uploaded patch set 2 12/28/14, 15:11
-
Jigal van Hemert commented on patch set 2 CR -1 12/28/14, 15:56
Most of the cases are comments, which do not need to be reviewed. Found a few cases which are public properties and functions. I don't think these can be changed unfortunately. One case has another typo in a unit test name. For the public members I have to give it a mild -1. Without these it can be merged as no-brainer.ArrayUtilityTest.php:416Also: "Accpets" instead of "Accepts"TypoScriptFrontendController.php:288This is a public property of TSFE; can't really change it (even though it may not be used a lot)SearchFormController.php:1160Also a public function which may be used by extensions (specific changes in indexed_search functionality). -
Stephan Großberndt commented on patch set 2 12/28/14, 22:19
SearchFormController.php:1160ReplyWhat about renaming the real function to checkExistence, creating a new public function checkExistance() which just calls and returns checkExistence() and deprecate it? -
Helmut Hummel uploaded patch set 3 12/28/14, 23:06
-
Helmut Hummel commented on patch set 2 12/28/14, 23:06
ArrayUtilityTest.php:416ReplyDoneTypoScriptFrontendController.php:288ReplyDoneSearchFormController.php:1160ReplyDone -
Helmut Hummel commented on patch set 3 CR +2 V +2 12/28/14, 23:07
nothing to verify really, as these are comment changes only -
Stephan Großberndt commented on patch set 2 12/29/14, 10:37
so checkExistance() stays? I'd still vote for changing checkExistance() to checkExistence() and creating a new deprecated checkExistance() { return checkExistence(); } so we can get rid of this mistake in CMS 8 -
Wouter Wolters commented on patch set 3 V +2 CR +2 12/29/14, 10:57
Stephan, this can be done in a new review. This change is only to fix common misspellings and typos -
Wouter Wolters merged patch set 3 12/29/14, 10:57