Review main Merged

35661[TASK] Fix common misspellings and typos

Wouter Wolters CR +2 V +2 Normal +96 −96 updated 12/29/14, 10:57

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Helmut Hummel +2
  • Verified V +2
    • Wouter Wolters +2
    • Helmut Hummel +2

Issues 1

Files 72

Show 52 more files

Review log 10

  1. Wouter Wolters uploaded patch set 1 12/28/14, 14:53

  2. Wouter Wolters uploaded patch set 2 12/28/14, 15:11

  3. Jigal van Hemert commented on patch set 2 CR -1 12/28/14, 15:56

    Most of the cases are comments, which do not need to be reviewed. Found a few cases which are public properties and functions. I don't think these can be changed unfortunately. One case has another typo in a unit test name. For the public members I have to give it a mild -1. Without these it can be merged as no-brainer.

    ArrayUtilityTest.php:416

    Also: "Accpets" instead of "Accepts"

    TypoScriptFrontendController.php:288

    This is a public property of TSFE; can't really change it (even though it may not be used a lot)

    SearchFormController.php:1160

    Also a public function which may be used by extensions (specific changes in indexed_search functionality).
  4. Stephan Großberndt commented on patch set 2 12/28/14, 22:19

    SearchFormController.php:1160 Reply

    What about renaming the real function to checkExistence, creating a new public function checkExistance() which just calls and returns checkExistence() and deprecate it?
  5. Helmut Hummel uploaded patch set 3 12/28/14, 23:06

  6. Helmut Hummel commented on patch set 2 12/28/14, 23:06

    ArrayUtilityTest.php:416 Reply

    Done

    TypoScriptFrontendController.php:288 Reply

    Done

    SearchFormController.php:1160 Reply

    Done
  7. Helmut Hummel commented on patch set 3 CR +2 V +2 12/28/14, 23:07

    nothing to verify really, as these are comment changes only
  8. Stephan Großberndt commented on patch set 2 12/29/14, 10:37

    so checkExistance() stays? I'd still vote for changing checkExistance() to checkExistence() and creating a new deprecated checkExistance() { return checkExistence(); } so we can get rid of this mistake in CMS 8
  9. Wouter Wolters commented on patch set 3 V +2 CR +2 12/29/14, 10:57

    Stephan, this can be done in a new review. This change is only to fix common misspellings and typos
  10. Wouter Wolters merged patch set 3 12/29/14, 10:57