Review main Merged

35668[BUGFIX] Properly set checked attribute for objects

Mathias Brodala CR +2 V +2 Normal +62 −12 updated 04/23/15, 15:29

Commit message

This makes sure the checked attribute is properly set by the
CheckboxViewHelper for a list of objects.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2
    • Andreas Kienast +2
    • Markus Klein +1

Issues 1

Files 3

Review log 21

  1. Mathias Brodala uploaded patch set 1 12/30/14, 09:14

  2. Mathias Brodala uploaded patch set 2 12/30/14, 09:15

  3. Mathias Brodala uploaded patch set 3 12/30/14, 09:17

  4. Mathias Schreiber wrote 01/02/15, 17:31

    Topic set to EXT: fluid
  5. Mathias Brodala uploaded patch set 4 04/01/15, 08:52

  6. Nicole Hummel commented on patch set 4 V -1 04/01/15, 14:21

  7. Mathias Brodala commented on patch set 4 04/01/15, 14:48

    I'll fix it.
  8. Mathias Brodala uploaded patch set 5 04/01/15, 15:05

  9. Andreas Kienast commented on patch set 5 04/01/15, 18:01

    AbstractFormFieldViewHelper.php:127

    no need to store this into a variable, you can return it directly.

    AbstractFormFieldViewHelper.php:135

    bool

    AbstractFormFieldViewHelper.php:139

    not needed
  10. Mathias Brodala commented on patch set 5 04/02/15, 06:26

    You are absolutely right, I only moved the code to a separate method without cleanup. ;-)
  11. Mathias Brodala commented on patch set 5 04/02/15, 06:38

    AbstractFormFieldViewHelper.php:127 Reply

    Done

    AbstractFormFieldViewHelper.php:135 Reply

    Done

    AbstractFormFieldViewHelper.php:139 Reply

    Done
  12. Mathias Brodala uploaded patch set 6 04/02/15, 06:38

  13. Nicole Hummel commented on patch set 6 V -1 04/02/15, 09:27

  14. Mathias Brodala rebased onto patch set 6 04/07/15, 08:21

  15. Sebastian Fischer voted on patch set 7 CR +1 04/07/15, 08:52

  16. Markus Klein commented on patch set 7 CR -1 04/19/15, 12:02

    AbstractFormFieldViewHelper.php:138

    if $convertObjects is FALSE we do nothing in this function? IMHO that does not make sense. remove the parameter and do the check before the call.
  17. Mathias Brodala commented on patch set 7 04/21/15, 09:31

    AbstractFormFieldViewHelper.php:138 Reply

    Please see the whole call stack. This is how the code works as of now. I wouldn't mind dropping this since it's internal API and no location passes FALSE to getValue() ATM but I'm not sure about the implications for 3rd party code.
  18. Markus Klein uploaded patch set 8 04/22/15, 18:01

  19. Markus Klein commented on patch set 8 CR +1 V +1 04/22/15, 18:02

    tested with unittests only
  20. Andreas Kienast voted on patch set 8 CR +2 V +2 04/23/15, 15:29

  21. Andreas Kienast merged patch set 8 04/23/15, 15:29