Review TYPO3_6-2 Merged

35687[BUGFIX] deleteRecord_flexFormCallBack deletes file_references

Benni Mack CR +2 V +2 Easy +2 −2 updated 12/31/14, 10:47

Commit message

Files that are referenced in a flexform
<type>group</type><internal_type>file_reference</internal_type>
will be deleted by deleteRecord_flexFormCallBack() in
t3lib_TCEmain, independent of the path or usage by other records.

For normal record fields (e.g. tt_content.images), only file
with the internal_type "file" are deleted. Files of
internal_type "file_reference" are respected and will not be
deleted. There is an appropriate condition in
t3lib_TCEmain::extFileFunctions().

But for flexform fields, this differentiation in handling
between both internal_types is missing.

Therefore using lowlevel_cleaner or the delete option in the
recycler will delete files that may be still in use. The
flexFormCallBack must be changed to delete only files of
internal_type "file".

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2

Files 1

Review log 2

  1. Benni Mack voted on patch set 1 V +2 CR +2 12/31/14, 10:47

  2. Benni Mack merged patch set 1 12/31/14, 10:47