35691[FEATURE] Add stdWrap for title tag
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Mathias Schreiber +1
- Stefan Froemken +1
-
Verified V +2
- Markus Klein +2
- Mathias Schreiber +1
- Stefan Froemken +1
Issues 1
Files 2
Review log 15
-
Benni Mack uploaded patch set 1 12/31/14, 12:45
-
Benni Mack wrote 12/31/14, 20:05
Topic set to TypoScript -
Mathias Schreiber voted on patch set 1 CR +1 V +1 01/04/15, 15:17
-
Daniel Maier commented on patch set 1 CR -1 01/04/15, 15:28
Feature-33491-StdWrapForTitleTag.rst:12this sentence is not very clear... better perhaps simpy: The new option can be used like this (...) -
Daniel Maier commented on patch set 1 01/04/15, 15:29
Just some nitpicking: The how-to-use discription in rst is not that clear IMO -
Mathias Schreiber commented on patch set 1 01/04/15, 15:30
Typos in Documentation will be fixed by me anyways. -
Benni Mack uploaded patch set 2 01/04/15, 15:44
-
Daniel Maier voted on patch set 2 CR +1 V +1 01/04/15, 16:12
-
Stefan Froemken commented on patch set 2 V +1 CR +1 01/04/15, 20:36
Feature-33491-StdWrapForTitleTag.rst:17IMO the idea behind page.config is to configure frame-based websites. I would prefer to use config as TLO here. -
Markus Klein commented on patch set 2 CR -1 01/04/15, 20:59
Feature-33491-StdWrapForTitleTag.rst:10It does NOT take precedence, but is executed as last step.Feature-33491-StdWrapForTitleTag.rst:17ReplyThe idea is to override config on a per PAGE basis. -
Mathias Schreiber uploaded patch set 3 01/05/15, 08:18
-
Mathias Schreiber commented on patch set 3 CR +1 V +1 01/05/15, 08:19
Clarified documentation. Good catch Markus -
Stefan Froemken voted on patch set 3 CR +1 V +1 01/05/15, 08:51
-
Markus Klein voted on patch set 3 CR +2 V +2 01/05/15, 12:51
-
Markus Klein merged patch set 3 01/05/15, 12:51