Review main Merged

35691[FEATURE] Add stdWrap for title tag

Benni Mack CR +2 V +2 Easy +23 −2 updated 01/05/15, 12:51

Commit message

In order to manipulate the title tag in a
flexible manner, the stdWrap option for
the title tag is introduced with the following
parameter:

config.pageTitle

As an example, one can now make the title
tag contents all uppercase.

config.pageTitle.case = upper

Review

  • Code review CR +2
    • Markus Klein +2
    • Mathias Schreiber +1
    • Stefan Froemken +1
  • Verified V +2
    • Markus Klein +2
    • Mathias Schreiber +1
    • Stefan Froemken +1

Issues 1

Files 2

Review log 15

  1. Benni Mack uploaded patch set 1 12/31/14, 12:45

  2. Benni Mack wrote 12/31/14, 20:05

    Topic set to TypoScript
  3. Mathias Schreiber voted on patch set 1 CR +1 V +1 01/04/15, 15:17

  4. Daniel Maier commented on patch set 1 CR -1 01/04/15, 15:28

    Feature-33491-StdWrapForTitleTag.rst:12

    this sentence is not very clear... better perhaps simpy: The new option can be used like this (...)
  5. Daniel Maier commented on patch set 1 01/04/15, 15:29

    Just some nitpicking: The how-to-use discription in rst is not that clear IMO
  6. Mathias Schreiber commented on patch set 1 01/04/15, 15:30

    Typos in Documentation will be fixed by me anyways.
  7. Benni Mack uploaded patch set 2 01/04/15, 15:44

  8. Daniel Maier voted on patch set 2 CR +1 V +1 01/04/15, 16:12

  9. Stefan Froemken commented on patch set 2 V +1 CR +1 01/04/15, 20:36

    Feature-33491-StdWrapForTitleTag.rst:17

    IMO the idea behind page.config is to configure frame-based websites. I would prefer to use config as TLO here.
  10. Markus Klein commented on patch set 2 CR -1 01/04/15, 20:59

    Feature-33491-StdWrapForTitleTag.rst:10

    It does NOT take precedence, but is executed as last step.

    Feature-33491-StdWrapForTitleTag.rst:17 Reply

    The idea is to override config on a per PAGE basis.
  11. Mathias Schreiber uploaded patch set 3 01/05/15, 08:18

  12. Mathias Schreiber commented on patch set 3 CR +1 V +1 01/05/15, 08:19

    Clarified documentation. Good catch Markus
  13. Stefan Froemken voted on patch set 3 CR +1 V +1 01/05/15, 08:51

  14. Markus Klein voted on patch set 3 CR +2 V +2 01/05/15, 12:51

  15. Markus Klein merged patch set 3 01/05/15, 12:51