Review main Merged

35724[BUGFIX] csc-uploads delivers broken CSS

Benni Mack CR +2 V +2 Easy +1 −1 updated 01/02/15, 14:45

Commit message

In CSS Styled Content the CSS rule

ul.csc-uploads img { float: left; padding-right: 1em; vertical-align: top; }

causes images to be squeezed when they have the
width-attr (default=150, through
tt_content.uploads.20.renderObj.10.file.width) set
because the 1em is calculated inside the given
dimensions. The padding should be changed to
margin, otherwise all images are squeezed
horizontally regardless of the actual
dimension settings.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Mathias Schreiber +1
  • Verified V +2
    • Wouter Wolters +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 7

  1. Benni Mack uploaded patch set 1 01/02/15, 11:04

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 01/02/15, 11:08

  3. Mathias Schreiber voted on patch set 1 CR +1 V +1 01/02/15, 11:11

  4. Wouter Wolters voted on patch set 1 V +2 CR +2 01/02/15, 11:54

  5. Wouter Wolters merged patch set 1 01/02/15, 11:54

  6. Wouter Wolters commented on patch set 2 01/02/15, 11:54

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 420c6a3c2c482baacbac411a0acbd33b96f394f4
  7. Markus Klein commented on patch set 2 01/02/15, 14:45

    Isn't that a breaking change on 6.2? All of a sudden a different CSS is rendered, which might interfere with CSS of the site.