35730[BUGFIX] Web->Function: empty frame if all related ext removed
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Markus Klein +1
-
Verified V +2
- Benni Mack +2
- Markus Klein +1
Issues 1
Files 2
Review log 17
-
Mathias Schreiber uploaded patch set 1 01/02/15, 11:35
-
Mathias Schreiber updated the commit message in patch set 2 01/02/15, 11:36
-
Andreas Kienast uploaded patch set 3 01/02/15, 12:42
-
Andreas Kienast uploaded patch set 4 01/02/15, 12:45
-
Mathias Schreiber voted on patch set 4 CR +1 V +1 01/02/15, 12:45
-
Markus Klein commented on patch set 4 CR -1 01/02/15, 13:45
@mattes: you're the author, your votes do not countBaseScriptClass.php:239still using the globalBaseScriptClass.php:273check from gerrit 35515 missing here! -
Markus Klein commented on patch set 4 01/02/15, 13:51
Needs to be fixed for 6.2 as well, see gerrit 35515 -
Mathias Schreiber uploaded patch set 5 01/02/15, 13:56
-
Mathias Schreiber commented on patch set 5 CR -2 01/02/15, 13:57
maaaaan.... gimme a second -
Mathias Schreiber uploaded patch set 6 01/02/15, 13:59
-
Mathias Schreiber commented on patch set 6 CR 0 01/02/15, 14:00
ok. Regarding the votes: Andy uploaded another patchset so the votes should've applied to those. How to handle in the future? -
Markus Klein commented on patch set 6 01/02/15, 14:48
If Andy changed the patch substantially, then the authorship should be his and your votes are fine. -
Benni Mack voted on patch set 6 CR +1 V +1 01/02/15, 14:56
-
Markus Klein uploaded patch set 7 01/02/15, 15:29
-
Markus Klein voted on patch set 7 CR +1 V +1 01/02/15, 15:29
-
Benni Mack voted on patch set 7 CR +2 V +2 01/02/15, 15:48
-
Benni Mack merged patch set 7 01/02/15, 15:48