Review main Merged

35732[TASK] Make be_sessions.ses_data text field for HHVM

Benni Mack CR +2 V +2 Easy +1 −1 updated 01/03/15, 22:50

Commit message

The ses_date field of the DB table be_sessions can
hold up to 4GB of data, which is never used.

It also does not work on HHVM (see forge ticket).

Changing it to type text is sufficient.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Mathias Schreiber +1
  • Verified V +2
    • Wouter Wolters +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 9

  1. Benni Mack uploaded patch set 1 01/02/15, 11:43

  2. Mathias Schreiber voted on patch set 1 CR +1 V +1 01/02/15, 11:44

  3. Wouter Wolters voted on patch set 1 V +2 CR +2 01/02/15, 11:47

  4. Wouter Wolters merged patch set 1 01/02/15, 11:47

  5. Tymoteusz Motylewski commented on patch set 2 01/02/15, 13:27

    post merge -1. according to the ticket on HHVM github, this issue was already resolved on HHVM side. Did anybody actually tested it with recent HHVM and found out that it doesn't work? What about dbal ? how much data can text column hold in postgres, oracle and mssql? This is also a breaking change for me, so it should at last have [!!!].
  6. Mathias Schreiber commented on patch set 2 01/02/15, 13:30

    PG: variable unlimited length OCi: 4GB MSSQL: 4GB DB2: 2GB Storing that much data in your DB. Plus adoDB translates into the respective datatypes anyways so It's not breaking
  7. Markus Klein commented on patch set 2 01/02/15, 14:41

    I also totally miss the reasoning about why we can shorten it now again albeit the size was extended over time? That was done for a reason, I guess.
  8. Helmut Hummel commented on patch set 2 01/03/15, 22:50

    I agree this should be reverted! The size of the sessiondata was increased from mediumtext to longtext in 4.1 for " publishing many records may cause PHP timeout and leave workspace in half-published state" sha1 61bd435a503e86c2c31b6c219aae9e58a1c6b5d7 (and some following). This change introduced storing *all* records that are published in the process into the session. Although the workspace module code changed a lot since then, looking at it now I have the impression that even more things are stored in the session. I haven't checked how much data could be stored, but text seems to small for me. Until we're completely sure whether mediumtext (or any other lenght) is enough we should revert this.
  9. Helmut Hummel commented on patch set 2 01/03/15, 22:50

    Reverted This patchset was reverted in change: I09244ede46c91a7fd11eb0e9733dc3111ebbf0df