Review main Merged

35748[CLEANUP] Use $this-> instead of parent:: in TS Conditions

Benni Mack CR +2 V +2 Easy +6 −6 updated 04/25/15, 19:49

Commit message

The code for Backend and Frontend TS conditions
uses static calls to parent:: instead of using
$this->, which is common throughout the rest
of the TYPO3 Core.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 7

  1. Benni Mack uploaded patch set 1 01/02/15, 21:26

  2. Benni Mack commented on patch set 1 01/02/15, 21:26

    Markus, this one is for you.
  3. Wouter Wolters commented on patch set 1 V +1 CR +1 01/03/15, 11:05

    Good catch Markus!
  4. Markus Klein voted on patch set 1 CR +2 V +2 01/03/15, 12:34

  5. Markus Klein merged patch set 1 01/03/15, 12:34

  6. Stefan Neufeind commented on patch set 2 01/03/15, 16:03

    Thanks, of course. That came from the original ConditionMatcher we had until now. (It's also in 6.2 ... but doesn't really need a fix there imho, since it's not critical.)
  7. Markus Klein commented on patch set 2 04/25/15, 19:49

    now reported for 6.2, will backport