Review main Merged

35750[BUGFIX] Allow page.config.pageTitleSeparator

Benni Mack CR +2 V +2 Easy +25 −16 updated 01/08/15, 19:50

Commit message

The TypoScript option page.config.pageTitleSeparator
does not work currently, however the unspecific option
config.pageTitleSeparator does work.

This is due to the fact that the PageGenerator class
is preparing all options with TSFE->config and the
TemplateService class is putting everything together
with tmpl->setup which is not the consolidated config
data for this page. In order to streamline the code,
the pageTitleSeparator logic is moved
to PageGenerator where TSFE->config is used instead.

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Klein +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Markus Klein +1
    • Christian Kuhn +1

Issues 1

Files 2

Review log 16

  1. Benni Mack uploaded patch set 1 01/03/15, 10:23

  2. Markus Klein commented on patch set 1 01/03/15, 14:52

    Please describe the change and not the bug
    Testing instructions should be in forge ticket
  3. Benni Mack uploaded patch set 2 01/07/15, 00:32

  4. Markus Klein voted on patch set 2 CR +1 01/07/15, 00:54

  5. Bill Dagou commented on patch set 2 CR +1 V +1 01/07/15, 01:39

    The changes work on my end. Thanks!
  6. Markus Klein commented on patch set 2 01/07/15, 12:03

    will push an update

    PageGenerator.php:1116

    This can be shortened to !empty(), but I would prefer to compare to !== ''
  7. Markus Klein uploaded patch set 3 01/07/15, 12:15

  8. Markus Klein voted on patch set 3 CR +1 V +1 01/07/15, 12:16

  9. Benni Mack commented on patch set 3 01/08/15, 08:46

    hey bill, can you re-apply your votes?
  10. Christian Kuhn voted on patch set 3 CR +1 V +1 01/08/15, 13:56

  11. Benni Mack voted on patch set 3 CR +2 V +2 01/08/15, 14:14

  12. Benni Mack merged patch set 3 01/08/15, 14:14

  13. Helmut Hummel commented on patch set 4 01/08/15, 14:19

    -1 for having this change like that in 6.2

    TemplateService.php:1276

    this changes public API! Really target 6.2? Why?
  14. Wouter Wolters commented on patch set 4 01/08/15, 16:15

    TemplateService.php:1276 Reply

    public API doesn't change here.. but is extended with a optional parameter.
  15. Benni Mack commented on patch set 4 01/08/15, 19:49

    fine with me, let's keep it out of 6.2.
  16. Benni Mack commented on patch set 4 01/08/15, 19:50

    I don't mind, just found this one on forge.