35750[BUGFIX] Allow page.config.pageTitleSeparator
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Markus Klein +1
- Christian Kuhn +1
-
Verified V +2
- Benni Mack +2
- Markus Klein +1
- Christian Kuhn +1
Issues 1
Files 2
Review log 16
-
Benni Mack uploaded patch set 1 01/03/15, 10:23
-
Markus Klein commented on patch set 1 01/03/15, 14:52
Please describe the change and not the bugTesting instructions should be in forge ticket -
Benni Mack uploaded patch set 2 01/07/15, 00:32
-
Markus Klein voted on patch set 2 CR +1 01/07/15, 00:54
-
Bill Dagou commented on patch set 2 CR +1 V +1 01/07/15, 01:39
The changes work on my end. Thanks! -
Markus Klein commented on patch set 2 01/07/15, 12:03
will push an updatePageGenerator.php:1116This can be shortened to !empty(), but I would prefer to compare to !== '' -
Markus Klein uploaded patch set 3 01/07/15, 12:15
-
Markus Klein voted on patch set 3 CR +1 V +1 01/07/15, 12:16
-
Benni Mack commented on patch set 3 01/08/15, 08:46
hey bill, can you re-apply your votes? -
Christian Kuhn voted on patch set 3 CR +1 V +1 01/08/15, 13:56
-
Benni Mack voted on patch set 3 CR +2 V +2 01/08/15, 14:14
-
Benni Mack merged patch set 3 01/08/15, 14:14
-
Helmut Hummel commented on patch set 4 01/08/15, 14:19
-1 for having this change like that in 6.2TemplateService.php:1276this changes public API! Really target 6.2? Why? -
Wouter Wolters commented on patch set 4 01/08/15, 16:15
TemplateService.php:1276Replypublic API doesn't change here.. but is extended with a optional parameter. -
Benni Mack commented on patch set 4 01/08/15, 19:49
fine with me, let's keep it out of 6.2. -
Benni Mack commented on patch set 4 01/08/15, 19:50
I don't mind, just found this one on forge.