Review main Merged

35762Revert "[TASK] Make be_sessions.ses_data text field for HHVM"

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 01/05/15, 12:47

Commit message

This reverts commit 8b8ad8e4bd5ee569ede588070aa6cf364b2580f0

64k will not be enough space for session data which can get larger
in certain usecases (e.g. workspaces).

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Files 1

Review log 8

  1. Markus Klein commented on patch set 1 CR -1 V +1 01/03/15, 23:48

    We need some more details in the commit message. So -1 until we agree on the revert and added those details.
  2. Mathias Schreiber updated the commit message in patch set 2 01/05/15, 08:59

  3. Mathias Schreiber voted on patch set 2 CR +1 V +1 01/05/15, 08:59

  4. Markus Klein commented on patch set 2 01/05/15, 12:31

    Will add the missing information now and will merge this then.
  5. Markus Klein updated the commit message in patch set 3 01/05/15, 12:46

  6. Markus Klein updated the commit message in patch set 4 01/05/15, 12:46

  7. Markus Klein voted on patch set 4 CR +2 V +2 01/05/15, 12:47

  8. Markus Klein merged patch set 4 01/05/15, 12:47