35779[TASK] Suggest element refactoring
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 11
- typo3/sysext/backend/Classes/Form/Element/SuggestAjaxController.phpnew+414 −0
- typo3/sysext/backend/Classes/Form/Element/SuggestDefaultReceiver.php6+107 −71
- typo3/sysext/backend/Classes/Form/Element/SuggestElement.php+1 −200
- typo3/sysext/backend/Classes/Form/Suggest/HtmlListResultRenderer.php2new+131 −0
- typo3/sysext/backend/Classes/Form/Suggest/SearchResult.phpnew+86 −0
- typo3/sysext/backend/Classes/Form/FormEngine.php+10 −0
- typo3/sysext/backend/Resources/Private/Templates/FormEngine.html+7 −7
- typo3/sysext/backend/Resources/Public/JavaScript/jsfunc.tceforms_suggest.js+2 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −1
- typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/_element_tceforms.less+4 −8
- typo3/sysext/t3skin/Resources/Public/Css/visual/t3skin.css+4 −7
Review log 18
-
Wouter Wolters uploaded patch set 1 01/04/15, 17:09
-
Wouter Wolters uploaded patch set 2 01/04/15, 17:12
-
Wouter Wolters uploaded patch set 3 01/04/15, 18:22
-
Wouter Wolters uploaded patch set 4 01/04/15, 19:18
-
Stefan Froemken commented on patch set 4 01/04/15, 19:41
With this patch the autocomplete for example GRSP does not work anymore in FF and Chrome. -
Wouter Wolters commented on patch set 4 01/04/15, 19:51
What is GRSP? -
Stefan Froemken commented on patch set 4 01/04/15, 20:23
General Record Storage Page. Available in page properties. -
Markus Klein commented on patch set 4 CR -1 01/04/15, 21:24
Do we really need the ResultRenderer interface? The AjaxController should IMO be placed in a different folder, but not sure yet which one fits best.SuggestDefaultReceiver.php:146no need to have that per referenceSuggestDefaultReceiver.php:162that comment is a bit weird nowSuggestDefaultReceiver.php:176look into DatabaseConnection that type seems wrongHtmlListResultRenderer.php:111Do that once above; move this line to the very top -
Wouter Wolters uploaded patch set 5 01/04/15, 21:35
-
Wouter Wolters commented on patch set 4 01/04/15, 21:35
SuggestDefaultReceiver.php:146ReplyDoneSuggestDefaultReceiver.php:162ReplyDoneSuggestDefaultReceiver.php:176ReplyDoneHtmlListResultRenderer.php:111ReplyDone -
Wouter Wolters commented on patch set 5 CR -1 01/04/15, 21:40
Still debugging -
Mathias Brodala commented on patch set 5 01/05/15, 09:52
wizard -
Wouter Wolters commented on patch set 5 01/05/15, 10:01
Reply
typo3/sysext/backend/Classes/Form/Element/SuggestElement.php looks more like a suggest element! -
Mathias Brodala commented on patch set 5 01/05/15, 10:24
Reply
But the whole thing is about the suggest wizard, isn't it? ;-) -
Markus Klein commented on patch set 5 01/05/15, 11:20
IMO we should move the whole suggest wizard around to a proper place. It's a good chance to do that now. It is for sure not a form >element< but a wizard that is attached to an element. -
Wouter Wolters commented on patch set 5 01/05/15, 11:35
Yes we can do that now. This code is not made by me but by Andreas. So maybe contact him in this regard. He placed the classes like it is now. -
Markus Klein commented on patch set 5 01/05/15, 12:34
I know it's not yours, that's why I wait for Andreas to finalize his patch. ;-) -
Wouter Wolters abandoned the change 05/09/15, 13:47
Needs a complete rebase by hand anyway and updates according to House of Form by Lolli