Review main Abandoned

35779[TASK] Suggest element refactoring

Wouter Wolters CR 0 V 0 Expert +767 −294 updated 05/09/15, 13:47

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 11

Review log 18

  1. Wouter Wolters uploaded patch set 1 01/04/15, 17:09

  2. Wouter Wolters uploaded patch set 2 01/04/15, 17:12

  3. Wouter Wolters uploaded patch set 3 01/04/15, 18:22

  4. Wouter Wolters uploaded patch set 4 01/04/15, 19:18

  5. Stefan Froemken commented on patch set 4 01/04/15, 19:41

    With this patch the autocomplete for example GRSP does not work anymore in FF and Chrome.
  6. Wouter Wolters commented on patch set 4 01/04/15, 19:51

    What is GRSP?
  7. Stefan Froemken commented on patch set 4 01/04/15, 20:23

    General Record Storage Page. Available in page properties.
  8. Markus Klein commented on patch set 4 CR -1 01/04/15, 21:24

    Do we really need the ResultRenderer interface? The AjaxController should IMO be placed in a different folder, but not sure yet which one fits best.

    SuggestDefaultReceiver.php:146

    no need to have that per reference

    SuggestDefaultReceiver.php:162

    that comment is a bit weird now

    SuggestDefaultReceiver.php:176

    look into DatabaseConnection that type seems wrong

    HtmlListResultRenderer.php:111

    Do that once above; move this line to the very top
  9. Wouter Wolters uploaded patch set 5 01/04/15, 21:35

  10. Wouter Wolters commented on patch set 4 01/04/15, 21:35

    SuggestDefaultReceiver.php:146 Reply

    Done

    SuggestDefaultReceiver.php:162 Reply

    Done

    SuggestDefaultReceiver.php:176 Reply

    Done

    HtmlListResultRenderer.php:111 Reply

    Done
  11. Wouter Wolters commented on patch set 5 CR -1 01/04/15, 21:40

    Still debugging
  12. Mathias Brodala commented on patch set 5 01/05/15, 09:52

    wizard
  13. Wouter Wolters commented on patch set 5 01/05/15, 10:01

    Reply

    typo3/sysext/backend/Classes/Form/Element/SuggestElement.php looks more like a suggest element!
  14. Mathias Brodala commented on patch set 5 01/05/15, 10:24

    Reply

    But the whole thing is about the suggest wizard, isn't it? ;-)
  15. Markus Klein commented on patch set 5 01/05/15, 11:20

    IMO we should move the whole suggest wizard around to a proper place. It's a good chance to do that now. It is for sure not a form >element< but a wizard that is attached to an element.
  16. Wouter Wolters commented on patch set 5 01/05/15, 11:35

    Yes we can do that now. This code is not made by me but by Andreas. So maybe contact him in this regard. He placed the classes like it is now.
  17. Markus Klein commented on patch set 5 01/05/15, 12:34

    I know it's not yours, that's why I wait for Andreas to finalize his patch. ;-)
  18. Wouter Wolters abandoned the change 05/09/15, 13:47

    Needs a complete rebase by hand anyway and updates according to House of Form by Lolli