Review main Merged

35800[TASK] Deprecate TS property andWhere

Georg Ringer CR +2 V +2 Normal +60 −7 updated 01/08/15, 11:16

Commit message

As the property "where" got full stdWrap support, there is no
need to keep "andWhere".

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1

Issues 1

Files 9

Review log 17

  1. Georg Ringer uploaded patch set 1 01/05/15, 19:25

  2. Mathias Schreiber updated the commit message in patch set 2 01/05/15, 19:32

  3. Mathias Schreiber voted on patch set 2 CR +1 V +1 01/05/15, 19:32

  4. Markus Klein commented on patch set 2 01/05/15, 20:27

    ContentObjectRenderer.php:7915

    Should we provide a hint, where this happened? A user might have hard times finding the andWhere
  5. Markus Klein commented on patch set 2 01/05/15, 20:28

    We need to fix that in old csc TS files as well?
  6. Stefan Neufeind commented on patch set 2 CR -1 01/06/15, 14:03

    Looks okay in general, but please fix remarks from Markus.
  7. Georg Ringer uploaded patch set 3 01/08/15, 08:18

  8. Markus Klein commented on patch set 3 CR +1 V +1 01/08/15, 09:49

    I'm still not very happy with the message, but I guess we do not have better information at hand to guide the user to the place where the andWhere is used.
  9. Stefan Neufeind commented on patch set 3 CR +1 01/08/15, 10:12

    ack. Unfortunately we can't easily tell for example which file and row (in case of included TS) or so the andWhere resulted from.
  10. Christian Kuhn commented on patch set 3 CR -1 01/08/15, 10:21

    technically wrong information in .rst file, other than that patch looks fine :)

    Deprecation-25112-andWhere.rst:19

    Not correct: andWhere is a property of select, but not of stdWrap. Please rephrase.
  11. Markus Klein commented on patch set 3 01/08/15, 10:32

    Deprecation-25112-andWhere.rst:19 Reply

    thanks, I overlooked that. will push an update
  12. Markus Klein uploaded patch set 4 01/08/15, 10:34

  13. Markus Klein commented on patch set 4 CR +1 V +1 01/08/15, 10:34

    Hope it fits better now
  14. Stefan Neufeind voted on patch set 4 CR +1 01/08/15, 10:45

  15. Christian Kuhn voted on patch set 4 CR +1 V +1 01/08/15, 11:15

  16. Christian Kuhn voted on patch set 4 CR +2 V +2 01/08/15, 11:16

  17. Christian Kuhn merged patch set 4 01/08/15, 11:16