35800[TASK] Deprecate TS property andWhere
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Markus Klein +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
Issues 1
Files 9
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-25112-andWhere.rst2new+52 −0
- typo3/sysext/css_styled_content/static/v4.5/setup.txt+1 −1
- typo3/sysext/css_styled_content/static/v4.6/setup.txt+1 −1
- typo3/sysext/css_styled_content/static/v4.7/setup.txt+1 −1
- typo3/sysext/css_styled_content/static/v6.0/setup.txt+1 −1
- typo3/sysext/css_styled_content/static/v6.1/setup.txt+1 −1
- typo3/sysext/css_styled_content/static/v6.2/setup.txt+1 −1
- typo3/sysext/css_styled_content/static/setup.txt+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php1+1 −0
Review log 17
-
Georg Ringer uploaded patch set 1 01/05/15, 19:25
-
Mathias Schreiber updated the commit message in patch set 2 01/05/15, 19:32
-
Mathias Schreiber voted on patch set 2 CR +1 V +1 01/05/15, 19:32
-
Markus Klein commented on patch set 2 01/05/15, 20:27
-
Markus Klein commented on patch set 2 01/05/15, 20:28
We need to fix that in old csc TS files as well? -
Stefan Neufeind commented on patch set 2 CR -1 01/06/15, 14:03
Looks okay in general, but please fix remarks from Markus. -
Georg Ringer uploaded patch set 3 01/08/15, 08:18
-
Markus Klein commented on patch set 3 CR +1 V +1 01/08/15, 09:49
I'm still not very happy with the message, but I guess we do not have better information at hand to guide the user to the place where the andWhere is used. -
Stefan Neufeind commented on patch set 3 CR +1 01/08/15, 10:12
ack. Unfortunately we can't easily tell for example which file and row (in case of included TS) or so the andWhere resulted from. -
Christian Kuhn commented on patch set 3 CR -1 01/08/15, 10:21
technically wrong information in .rst file, other than that patch looks fine :)Deprecation-25112-andWhere.rst:19Not correct: andWhere is a property of select, but not of stdWrap. Please rephrase. -
Markus Klein commented on patch set 3 01/08/15, 10:32
Deprecation-25112-andWhere.rst:19Replythanks, I overlooked that. will push an update -
Markus Klein uploaded patch set 4 01/08/15, 10:34
-
Markus Klein commented on patch set 4 CR +1 V +1 01/08/15, 10:34
Hope it fits better now -
Stefan Neufeind voted on patch set 4 CR +1 01/08/15, 10:45
-
Christian Kuhn voted on patch set 4 CR +1 V +1 01/08/15, 11:15
-
Christian Kuhn voted on patch set 4 CR +2 V +2 01/08/15, 11:16
-
Christian Kuhn merged patch set 4 01/08/15, 11:16
ContentObjectRenderer.php:7915