Review TYPO3_6-2 Abandoned

35804[FEATURE] output broken file links with pid in csv format

Urs Braem CR 0 V 0 Normal +32 −30 updated 01/05/15, 22:29

Commit message

When upgrading a site, manual correction of broken links
found by the RTE-FAL upgrade wizard is simpified:
from the error message, a spreadsheet can be created
and sorted by pid.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 4

  1. Urs Braem uploaded patch set 1 01/05/15, 20:46

  2. Markus Klein commented on patch set 1 01/05/15, 21:00

    That can't be a feature, but maybe a TASK. No new features for released branches.

    RteFileLinksUpdateWizard.php:183

    We use uppercase constants => NULL

    RteFileLinksUpdateWizard.php:185

    you mixed something in the code, that function is now defined twice! Please enable all code inspections your IDE (we recommend phpstorm!), so it warns you about such mistakes.

    RteFileLinksUpdateWizard.php:211

    trailing space. please configure your IDE to remove them automatically.
  3. Urs Braem commented on patch set 1 01/05/15, 21:28

    > (4 comments) Sorry again, I replied via forge, as I didn't find the reply button yet. Line 182: That's already in the code. I'll make a new commit and push that.
  4. Markus Klein abandoned the change 01/05/15, 22:29

    New set has been pushed with another change-id