Review TYPO3_6-2 Abandoned

35805[TASK] output broken file links with pid in csv format

Urs Braem CR 0 V 0 Normal +39 −31 updated 01/06/15, 15:58

Commit message

When upgrading a site, manual correction of broken links
found by the RTE-FAL upgrade wizard is simpified:
from the error message, a spreadsheet can be created
and sorted by pid.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 4

  1. Urs Braem uploaded patch set 1 01/05/15, 21:30

  2. Markus Klein commented on patch set 1 01/05/15, 22:28

    You pushed a completely new patch instead of a simple update. You've to preserve the change-id line in the commit message. http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine#Improving_the_patch_and_uploading_a_new_Patch_Set I'll abandon the other one
  3. Markus Klein commented on patch set 1 01/05/15, 23:24

    You didn't create this patch against a clean 6.2 branch. I suppose you had still the old commit there. Please always make your changes against a clean branch. Please configure your git to use your real name. Feel free to get in touch with me if you need help with setting up your git.
  4. Urs Braem abandoned the change 01/06/15, 15:58

    Abandoning the commit to restart again