Review main Merged

35812[BUGFIX] Passwords must be encrypted when saving records

Nils Heuermann CR +2 V +2 Easy +4 −4 updated 01/17/15, 22:21

Commit message

Due to old class names in the formevals configuration passwords were
not encrypted by saltedpasswords. Using the namespaced class names in
the configuration ensures that the evaluator methods are called.

Review

  • Code review CR +2
    • Markus Klein +2
    • Xavier Perseguers +2
    • Helmut Hummel +2
    • Stefan Neufeind +1
    • Philipp Gampe +1
  • Verified V +2
    • Markus Klein +2
    • Xavier Perseguers +2
    • Helmut Hummel +2

Issues 1

Files 3

Review log 8

  1. Nils Heuermann uploaded patch set 1 01/06/15, 08:36

  2. Markus Klein commented on patch set 1 CR +2 V +2 01/06/15, 12:00

    Extremely good and important catch!!
  3. Helmut Hummel voted on patch set 1 CR +2 V +2 01/06/15, 12:04

  4. Stefan Neufeind voted on patch set 1 CR +1 01/06/15, 12:47

  5. Xavier Perseguers voted on patch set 1 CR +1 01/06/15, 13:05

  6. Xavier Perseguers voted on patch set 1 V +2 CR +2 01/06/15, 13:08

  7. Philipp Gampe commented on patch set 1 CR +1 01/06/15, 13:35

    OK as bugfix, but we should change the logic of this setting to the regular userfunc definition: $conf['key'] = ClassName->function() instead of $conf['ClassName->function()'] = "file". Although this should be a follow up
  8. Mathias Schreiber merged patch set 1 01/17/15, 22:21