Review main Merged Breaking

35815[!!!][TASK] Clean up country/language flags

Benni Mack CR +2 V +2 Hard +326 −279 updated 01/07/15, 16:05

Commit message

The core has multiple places
where country flags are stored.

1. typo3/gfx/flags/ - a set of
non-normalized .gif files created by Robert
back in the days. No reference currently in
the usage inside the core since 4.5.

2. t3skin contains png files of a lot more
flags. They are used for selecting a flag
in sys_language records.

3. t3skin also delivers a sprite file with
all png icons. This is used for e.g. the list
view of sys_language records.

Thus, the core delivers flags (old ones, just a
few, as gif, not inside EXT:core) but they are
not in use since TYPO3 4.4. Also
it does not deliver sprites, however, uses the
sprites (flags-multiple etc) in list view already.

t3skin delivers a standard-set which should be
part of EXT:core, included in the right place
from the beginning so no dynamic TCA manipulation
is necessary in ext_tables.php.

Overriding of any styles, icons and sprites
is still possible.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Wouter Wolters +1

Issues 1

Files 561

Show 541 more files

Review log 9

  1. Benni Mack uploaded patch set 1 01/06/15, 11:30

  2. Benni Mack updated the commit message in patch set 2 01/06/15, 11:38

  3. Wouter Wolters commented on patch set 2 01/06/15, 23:02

    sysext/backend/Classes/Utility/BackendUtility.php 611: * Since TYPO3 4.5 the flagIcon is not returned as a filename in "gfx/flags/*" anymore, sysext/backend/Classes/Configuration/TranslationConfigurationProvider.php 30: * Since TYPO3 4.5 the flagIcon is not returned as a filename in "gfx/flags/*" anymore,
  4. Mathias Schreiber commented on patch set 2 CR +1 V +1 01/07/15, 14:53

    looks good from my side and the BE works as before on my tests.
  5. Benni Mack uploaded patch set 3 01/07/15, 15:30

  6. Mathias Schreiber voted on patch set 3 CR +1 V +1 01/07/15, 15:31

  7. Wouter Wolters voted on patch set 3 V +1 CR +1 01/07/15, 15:39

  8. Benni Mack voted on patch set 3 CR +2 V +2 01/07/15, 16:05

  9. Benni Mack merged patch set 3 01/07/15, 16:05