Review main Merged

35817[BUGFIX] Hidden content is displayed in view module

Stefan Froemken CR +2 V +2 Easy +1 −1 updated 01/15/15, 00:32

Commit message

Since TYPO3 4.2.3 hidden content elements and hidden
pages are displayed in view page module. There are many people
in the community who wants them to be hidden by default.
This patch reactivates the old way from TYPO3 4.2.2. If you
want to see the hidden elements again you have to add
config.admPanel = 1 in your TypoScript. The checkboxes
in admPanel to display hidden records works now again.

Review

  • Code review CR +2
    • Markus Klein +2
    • Frederic Gaus +1
    • Benni Mack +1
  • Verified V +2
    • Markus Klein +2
    • Frederic Gaus +1

Issues 1

Files 1

Review log 14

  1. Stefan Froemken uploaded patch set 1 01/06/15, 12:24

  2. Markus Klein commented on patch set 1 01/06/15, 12:51

    Is this new intended new behaviour or the bug?
  3. Stefan Froemken updated the commit message in patch set 2 01/06/15, 12:59

  4. Stefan Froemken commented on patch set 2 01/06/15, 13:03

    I don't know if this is a bug. There are people out there who are missing this feature since years and there are other persons who want to see hidden elements in Backend. But the problem is: In current version you can't hide hidden elements in view module. That's why I reactivate the old style from 4.2.2. Hidden elements are not shown by default now, but if you want to show them, you can activate them with help of the admPanel.
  5. Markus Klein commented on patch set 2 01/06/15, 15:42

    Well, you would typically use the view module to preview the state of a page. So you'd expect the hidden content to be visible, otherwise you could just use the frontend.
  6. Markus Klein commented on patch set 2 01/06/15, 19:42

    Why not modify \TYPO3\CMS\Viewpage\Controller\ViewModuleController::getAdminCommand() and remove the ADMCMD_view there from the URL?
  7. Stefan Froemken commented on patch set 2 01/09/15, 08:49

    For testing I have removed ADMCMD_view from URL and it works. But I don't know which sideeffects can appear. I will push a new patch.
  8. Stefan Froemken uploaded patch set 3 01/09/15, 08:54

  9. Benni Mack voted on patch set 3 CR +1 01/09/15, 08:56

  10. Markus Klein voted on patch set 3 CR +1 V +1 01/09/15, 11:02

  11. Frederic Gaus voted on patch set 3 CR +1 V +1 01/14/15, 22:42

  12. Markus Klein voted on patch set 3 CR +2 V +2 01/15/15, 00:31

  13. Markus Klein commented on patch set 3 01/15/15, 00:32

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 0af8f7a39fa4db06c4810981ab52c39b775fa8ad
  14. Markus Klein merged patch set 3 01/15/15, 00:32